Skip to content

Commit

Permalink
VST3 Host: Call updateMidiMapping() after enabling plug-in MIDI busse…
Browse files Browse the repository at this point in the history
…s in setupIO()

This fixes a crash in Roland Cloud plug-ins due to calling methods on the IMidiMapping interface before it was initialised.
  • Loading branch information
ed95 committed Sep 13, 2021
1 parent 5c933d4 commit 598748c
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -2248,7 +2248,6 @@ class VST3PluginInstance : public AudioPluginInstance
editController->setComponentHandler (holder->host);
grabInformationObjects();
interconnectComponentAndController();
updateMidiMappings();

auto configureParameters = [this]
{
Expand All @@ -2265,6 +2264,8 @@ class VST3PluginInstance : public AudioPluginInstance
if (getParameters().isEmpty() && editController->getParameterCount() > 0)
configureParameters();

updateMidiMappings();

parameterDispatcher.start (*editController);

return true;
Expand Down

0 comments on commit 598748c

Please sign in to comment.