juce_gui_basics: add missing header for std::exchange #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralgar
approved these changes
Jun 18, 2022
There was a problem hiding this comment.
Also on Arch Linux with GCC 12.1.0 here. Can confirm this issue, and I came here to submit this PR myself.
I agree with the location of the include, at least that it is in the correct file. It fixes the build error I was experiencing in modules/juice_gui_basics/windows/juce_ComponentPeer.h, when building juceaide.
|
Bumping this -- came to submit the same PR. |
|
This change, implemented in a different JUCE commit, has now been merged to master. Thank you for your submission. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes builds on ArchLinux with GCC 12 by adding a missing include in juce_gui_basics.
Feel free to criticize or edit if you think the include should be put somewhere else.