Bug fixes #8
Merged
Bug fixes #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's therefore not possble to just run #join on the given object.
Otherwise a 'SystemStackError: stack level too deep' will be raised.
trans
added a commit
that referenced
this pull request
Feb 27, 2012
Bug fixes for parent and run_git options.
| @@ -81,7 +81,7 @@ def tree?; self.class == Gash::Tree end | |||
| # Checks if this object has been changed (since last commit). | |||
| def changed?; !@sha1 end | |||
| # Mark this, and all parents as changed. | |||
| def changed!; @sha1 = nil;parent.changed! if parent end | |||
| def changed!; @sha1 = nil;parent.changed! if parent and not parent = self end | |||
There was a problem hiding this comment.
This doesn't work as intended. not parent = self will always be false.
There was a problem hiding this comment.
Oops. Missed an equal sign.
It should be and not parent == self.
I'll write some specs and fixed it later today.
oleander
added a commit
to water/gash
that referenced
this pull request
Feb 27, 2012
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some difficulties just getting Gash up and running.
After some debugging I found these buggs.
The commits have been "tested" against a bare gash repo using the following code.
The example above crashed without the following patches in both Ruby 1.8 and 1.9.
Give me a poke of you want be to add some real tests.
If so, a basic spec skeleton, like I explained in #7 would be awesome.