Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 CLI Documentation Formatting #185

Merged

Conversation

dhuppenkothen
Copy link
Contributor

Description

[//]: # Changed triple quotes to single quotes for help text in --equipment-id in cli.py. This now matches other help texts spanning multiple lines, and should fix the issue with compiling the options into a table.
[//]: # The options in the CLI documentation under "Campsites" does not compile correctly: from --equipment-id onwards, the table seems to break. This change hopefully fixes that issue and puts everything into their appropriate table.

Has This Been Tested?

[//]: # Unfortunately, I couldn't quite figure out how to compile the documentation on my own system, so that hasn't been tested yet. Happy to do so if the maintainers give me a pointer for how to compile the documentation. :)

Checklist:

  • [x ] I've read the contributing guidelines of this project
  • [ x] I've installed and used .pre_commit on all my code
  • [ x] I have documented my code, particularly in hard-to-understand areas
  • [ x] I have made any necessary corresponding changes to the documentation

@juftin
Copy link
Owner

juftin commented Jan 4, 2023

🏕️ thank you!!

You can generate the documentation locally with mkdocs (even easier, run it from within a poetry virtualenv with all the extra dependencies installed):

poetry install
poetry run mkdocs serve

I will get a chance to take a look at this myself soon.

@juftin
Copy link
Owner

juftin commented Jan 4, 2023

Before Change:
image

After Change:
image

camply/cli.py Outdated
""",
help="Search for campsites campaitble with specific equipment categories. Going To "
"Camp uses equipment category IDs for filtering campsites by equipment. Every "
"recreation area has equipment categories unique to it."
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're missing one small bit of whitespace here after "unique to it." See the screenshot @ #185 (comment)

@juftin
Copy link
Owner

juftin commented Jan 4, 2023

Okay - other than the whitespace comment above this looks good. There are a couple changes we'll need to make in order for this to deploy properly:

  1. When we finally commit this to main we'll need the commit message to conform to GitMoji. Performing a Squash Commit and titling it 📝 Fix formatting of options under campsites on CLI documentation will work (and I'll handle this when I push the merge button). There's some more info here on the commits/release rules here.

  2. Update the docs CI job to run on pushes instead of releases (since documentation changes don't trigger a new release). The code here will change to this:

on:
    push:
        branches: ['main']
        paths:
        -   camply/**
        -   docs/**
        -   .github/workflows/docs.yaml
        -   mkdocs.yml

I'm happy to handle this myself as well, let me know what works for you.

@juftin juftin changed the title Fix formatting of options under campsites on CLI documentation 📝 CLI Documentation Formatting Jan 6, 2023
@juftin juftin merged commit e47bf47 into juftin:main Jan 6, 2023
@juftin
Copy link
Owner

juftin commented Jan 25, 2023

🎉 This PR is included in version 0.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants