-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 CLI Documentation Formatting #185
📝 CLI Documentation Formatting #185
Conversation
…er documentation strings in cli.py
🏕️ thank you!! You can generate the documentation locally with mkdocs (even easier, run it from within a poetry virtualenv with all the extra dependencies installed):
I will get a chance to take a look at this myself soon. |
camply/cli.py
Outdated
""", | ||
help="Search for campsites campaitble with specific equipment categories. Going To " | ||
"Camp uses equipment category IDs for filtering campsites by equipment. Every " | ||
"recreation area has equipment categories unique to it." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're missing one small bit of whitespace here after "unique to it." See the screenshot @ #185 (comment)
Okay - other than the whitespace comment above this looks good. There are a couple changes we'll need to make in order for this to deploy properly:
on:
push:
branches: ['main']
paths:
- camply/**
- docs/**
- .github/workflows/docs.yaml
- mkdocs.yml I'm happy to handle this myself as well, let me know what works for you. |
🎉 This PR is included in version 0.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
[//]: # Changed triple quotes to single quotes for help text in
--equipment-id
incli.py
. This now matches other help texts spanning multiple lines, and should fix the issue with compiling the options into a table.[//]: # The options in the CLI documentation under "Campsites" does not compile correctly: from
--equipment-id
onwards, the table seems to break. This change hopefully fixes that issue and puts everything into their appropriate table.Has This Been Tested?
[//]: # Unfortunately, I couldn't quite figure out how to compile the documentation on my own system, so that hasn't been tested yet. Happy to do so if the maintainers give me a pointer for how to compile the documentation. :)
Checklist:
.pre_commit
on all my code