Add '--continuous' check when '--notifications' enabled

[acaloiaro]

If --notifications is provided without --continuous, it acts as a no-op, which can be confusing if you're testing notifications and don't realize that camply must be in continuous mode for notifications to be enabled.

---

Block on #92

[acaloiaro]

The concept of "continuous" mode isn't established elsewhere, is there a better way to phrase this?

[acaloiaro]

Would "To search campgrounds with..." be clearer?

Should errors messages use the full parameter notation, i.e. --notifications, or simply parameter names, i.e notifications. I personally prefer the former, but want error messaging to be consistent throughout the app.

[juftin]

Hmm. I like something like: To receive notifications about campsites you must be searching continuously by passing the --continuous option.

[juftin]

I like the mentioning of the full CLI arguments with the leading dashes

[juftin]

Sorry to be a formatting bug here, would you make sure the code is being formatted with pre-commit as well? https://juftin.com/camply/contributing.html

Maybe I should put this info on the GitHub too?

[acaloiaro]

Sorry to be a formatting bug here, would you make sure the code is being formatted with pre-commit as well? https://juftin.com/camply/contributing.html

Maybe I should put this info on the GitHub too?

Sure thing. Do you have any guidelines on when to add tests as well? This is a pretty simple PR, but it wouldn't be unreasonable to ask for additional test coverage over the new behavior.

[juftin]

I'm not terribly worried about a test for this change here.

In general, camply has pretty poor test coverage. I have a number of command line tests that run inside the tox commandline environment but they don't really prove test cases beyond asserting that all run successfully.

I'd like to improve this in the future but I can't be a stickler for it in the meantime. I've implemented a lot more without a new test.

[juftin]

👍