updated support for double definition, cf jshint#883

jugglinmike · Oct 21, 2014 · a9bb1a2 · a9bb1a2
1 parent 3c6676b
commit a9bb1a2
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/stable/jshint.js b/src/stable/jshint.js
@@ -498,9 +498,14 @@ var JSHINT = (function () {
 				}
 			}
 		}
-		// a double definition of a let variable throws a TypeError
-		if (state.option.esnext && funct["(blockscope)"].getlabelblock(t)) {
-			error("E044", state.tokens.next, t);
+		if (state.option.esnext) {
+			// a double definition of a let variable in same block throws a TypeError
+			if (_.has(funct["(curblock)"], t)) {
+				error("E044", state.tokens.next, t);
+			} else if (!state.option.shadow) {
+				if (funct["(blockscope)"].getlabelblock(t) || _.has(funct, t))
+					warning("W004", state.tokens.next, t);
+			}
 		}
 
 		// if the identifier is from a let, adds it only to the current blockscope