Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed several bugs #116

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Fixed several bugs #116

merged 2 commits into from
Jul 22, 2024

Conversation

lquenti
Copy link
Contributor

@lquenti lquenti commented May 7, 2024

Hi,

maybe this is weird, and sorry if so, but for a uni course I had to statically analyze some java library. Since I used labkit for some batch jython cell counting pipeline I wrote (thanks!), I wanted to give back by using it here.

What I found:

  • twice a bit operation instead of a boolean one. Shouldnt break the code, but not correct either
  • Once you used != for string comparison, which is a memory comparison.

@lquenti lquenti mentioned this pull request May 7, 2024
@maarzt maarzt merged commit 6514509 into juglab:master Jul 22, 2024
@maarzt
Copy link
Collaborator

maarzt commented Jul 22, 2024

@lquenti Thank you for reporting this bugs, and setting up the PR!
Sorry for the late response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants