Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #146

Closed
wants to merge 4 commits into from
Closed

Bug fixes #146

wants to merge 4 commits into from

Conversation

erikh
Copy link

@erikh erikh commented Jan 21, 2013

Sorry this pull request is a little coarse, it covers what needed to be done to get this plugin to work, which is a minimal bayesian classifier. https://gist.github.com/db708bfb439f3f9f91f3

Basically, I found a couple of major issues:

  • Something about EM 1.0 and twitter-stream 0.1.16, and the monkeypatch you made for reconnections is breaking with OS X complaining about ABI incompatibility. My ruby (1.9.3-p374, readline 6.2) is unfortunately stripped making this pretty hard to debug. Either way, removing the patch entirely seems to have resolved it, as this version of the gem runs start_tls after the connection is established by way of the standard EM connection_completed hook. So, I think we're good given there's not an issue on other platforms.
  • There's a reload command that happens every time a line of input is received from the user. This was causing every initializer to run, which was clearing all the output filters, making it virtually impossible to use them. I'm not having issues running without it, but it's possible I overlooked something.
  • The tweet output hook did not account for output filters. Probably a few other places this could be done too.

Let me know if you have any questions or need changes made. Thanks for a great tool!

@erikh erikh closed this Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant