Fix tuple params missing features #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `axum_extras`,`actix_extras` or `rocket_extras` was enabled the udpate of existing parameters did not take in account the features that was defined in the tuple style arguments and was overridden with empty features. This PR fixes this behavior where features will be also updated accordingly. Resolves #804
juhaku
force-pushed
the
fix-tuple-param-arguments
branch
from
5acf84d
to
16cfe35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
axum_extras,actix_extrasorrocket_extraswas enabled the udpate of existing parameters did not take in account the features that was defined in the tuple style arguments and was overridden with empty features. This PR fixes this behavior where features will be also updated accordingly.Resolves #804 Fixes #693