Skip to content

Commit

Permalink
Remove obsolete global ignore of promise lint rule
Browse files Browse the repository at this point in the history
  • Loading branch information
bkimminich committed Jan 9, 2022
1 parent cfff3d4 commit b376d66
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 3 deletions.
1 change: 0 additions & 1 deletion .eslintrc.js
Expand Up @@ -34,7 +34,6 @@ module.exports = {
rules: {
'no-void': 'off', // conflicting with recommendation from @typescript-eslint/no-floating-promises
// FIXME warnings below this line need to be checked and fixed. Line end comments below are number of findings per rule on 24.03.2021
'@typescript-eslint/no-misused-promises': 'off', // 97
'@typescript-eslint/explicit-function-return-type': 'off', // 132
'@typescript-eslint/restrict-plus-operands': 'off', // 292
'@typescript-eslint/strict-boolean-expressions': 'off', // 388
Expand Down
1 change: 1 addition & 0 deletions routes/languages.ts
Expand Up @@ -23,6 +23,7 @@ module.exports = function getLanguageList () { // TODO Refactor and extend to al
next(new Error(`Unable to read i18n directory: ${err.message}`))
}
languageFiles.forEach((fileName) => {
// eslint-disable-next-line @typescript-eslint/no-misused-promises
fs.readFile('frontend/dist/frontend/assets/i18n/' + fileName, 'utf-8', async (err, content) => {
if (err != null) {
next(new Error(`Unable to retrieve ${fileName} language file: ${err.message}`))
Expand Down
2 changes: 1 addition & 1 deletion test/apiTestsSetup.ts
Expand Up @@ -5,7 +5,7 @@

import server = require('./../server')

// eslint-disable-next-line no-async-promise-executor
// eslint-disable-next-line no-async-promise-executor,@typescript-eslint/no-misused-promises
export = async () => await new Promise(async (resolve, reject) =>
await server.start(err => {
if (err) {
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
Expand Up @@ -40,6 +40,6 @@
".eslintrc.js"
],
"ts-node": {
"transpileOnly": true // allow ts-node to run code with compile errors ignored. Remove this line after ts migration.
"transpileOnly": true // TODO Allows ts-node to run code with compile errors ignored. Remove this line after ts migration.
}
}

0 comments on commit b376d66

Please sign in to comment.