Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist language selection in cookie #523

Closed
bkimminich opened this issue Apr 9, 2018 · 4 comments
Closed

Persist language selection in cookie #523

bkimminich opened this issue Apr 9, 2018 · 4 comments

Comments

@bkimminich
Copy link
Member

At the moment angular-translate uses the Browser language by default. When selecting another language, it will be reset to this default whenever the AngularJS client is reloaded, e.g. on F5 or when a non-Angular page has been visited.

It would be nicer to store the last selection in a cookie and use it if present. Otherwise fall back to Browser default.

@bkimminich
Copy link
Member Author

Woah, that #524 was fast, @Aashish683! 👍

bkimminich added a commit that referenced this issue Apr 9, 2018
Fix #523 : Added cookie to store last selected language.
@Aashish683
Copy link
Contributor

Thanks @bkimminich , is there anything more which needs to be resolved for this issue ?

@bkimminich
Copy link
Member Author

No, works like a charm! 👍

@lock
Copy link

lock bot commented Nov 4, 2019

This thread has been automatically locked because it has not had recent activity after it was closed. 🔒 Please open a new issue for regressions or related bugs.

@lock lock bot locked and limited conversation to collaborators Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants