Fix createMemories() to download remote images #1351
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While creating a custom config I discovered memories would not load properly if the
image:
value was a URL.For example, a config YAML that is a direct copy of default.yml with a URL specified for one of the memory images like this:
Will result in a warning when starting up:
Also,
downloadToFile
increateMemories
looks like it was being called with the incorrect destination path, so I made it the same as increateProducts
.