Add workflow for auto updating the website on release #1355
Conversation
Signed-off-by: Scar26 <mmatty26@gmail.com>
Noice 😂 |
|
Btw. if I remember correctly not the bot account needs the rights, but the person doing the push. Which is either the one actually pushing directly to the master branch or the one who clicked the merge button on a PR. |
.github/workflows/updatewebsite.yml
Outdated
| wget https://raw.githubusercontent.com/bkimminich/juice-shop/master/data/static/challenges.yml | ||
| - uses: stefanzweifel/git-auto-commit-action@v4.0.0 | ||
| with: | ||
| commit_message: "update challenges.yml after juice-shop release" |
There was a problem hiding this comment.
The commit message is currently a bit incorrect as this would actually push on every commit to the master branch (which changes the challenges.yaml). Which happens more frequently than the releases.
Maybe it wold be better to make it run on tags rather than branches?
There was a problem hiding this comment.
No, I added the path property at the beginning so it only activates if changes to challenges.yml have been made
There was a problem hiding this comment.
But should I shift it to tags anyway?
|
Pushing to master is okay, then it is consistent with the demo Heroku instance. That deploys the master branch, not a tag. |
Fixes: #1337
The bot will have to be granted access to OWASP/www-project-juice-shop/ for this to work
P.S: Just realized the issue is numbered 1337