Do not validate challenge if "bid" is "NaN" #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Hi @cnotin! Excluding |
|
I caught the bug and fixed it! I guess Travis-CI is running in another PR and will come back to this one after :) |
This can occur if the Session Storage was cleared after login. "bid" was modified but it was surely unintentional and thus should not validate challenge Signed-off-by: Clément Notin <clement@notin.org>
It happens if we restart the app, we are somewhat still connected because of the JWT that remained but since we did not go through login then "user.bid" is not defined Signed-off-by: Clément Notin <clement@notin.org>
|
ℹ️ Unfortunately the Travis-CI pipeline is still unavailable due to missing OSS credits. I've pinged them on the respective support ticket once again, but haven't heard back from them yet. Reviews and merging of open PRs will resume once our CI/CD is back online. Thanks for your contribution and patience! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can occur if the Session Storage was cleared after login. "bid" was modified but it was surely unintentional and thus should not validate challenge.
CANCELLED: Also, do not rely on "user.bid" as it is defined at login but it is not set if we restart the app, keep our JWT but do not go through login again. Compare instead with the userid of the basket object we got from DB, through the given id