Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Server Crash on Undeliverable Challenge Solved Webhook #1514

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

J12934
Copy link
Member

@J12934 J12934 commented Nov 20, 2020

This can happen when the configured domain doesn't exist or doesn't respond at all.

This leads to errors like the following:

info: Solved challenge Score Board (Find the carefully hidden 'Score Board' page.)
error: Webhook notification failed: connect ECONNREFUSED 10.110.238.153:80
/juice-shop/lib/webhook.js:33
      throw error
      ^

Error: connect ECONNREFUSED 10.110.238.153:80
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1141:16) {
  errno: 'ECONNREFUSED',
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '10.110.238.153',
  port: 80
}
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! juice-shop@12.0.2 start: `node app`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the juice-shop@12.0.2 start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/juicer/.npm/_logs/2020-11-20T17_49_42_309Z-debug.log

Had to do some bigger changes than I expected so that the function properly throws and catches the async error and are usable in the server tests.

This can happen when the configured domain doesn't exist or doesn't respond at all.

Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
@bkimminich
Copy link
Member

ℹ️ Unfortunately the Travis-CI pipeline is still unavailable due to missing OSS credits. I've pinged them on the respective support ticket once again, but haven't heard back from them yet. Reviews and merging of open PRs will resume once our CI/CD is back online. Thanks for your contribution and patience! 👍

@bkimminich bkimminich merged commit 27d11eb into develop Dec 2, 2020
@J12934 J12934 deleted the fix/webhook-crash branch March 9, 2021 20:11
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants