Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bonus points to already existing orders #1515

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Add bonus points to already existing orders #1515

merged 1 commit into from
Dec 2, 2020

Conversation

cnotin
Copy link
Contributor

@cnotin cnotin commented Nov 21, 2020

Before:
image

After:
image

Signed-off-by: Clément Notin <clement@notin.org>
@bkimminich
Copy link
Member

Aaah, that's a great fix! 👍 Never noticed that before! Thanks! I'll merge it once the Travis-CI issues are gone!

@bkimminich
Copy link
Member

ℹ️ Unfortunately the Travis-CI pipeline is still unavailable due to missing OSS credits. I've pinged them on the respective support ticket once again, but haven't heard back from them yet. Reviews and merging of open PRs will resume once our CI/CD is back online. Thanks for your contribution and patience! 👍

@bkimminich bkimminich merged commit ca4fce3 into juice-shop:develop Dec 2, 2020
@bkimminich
Copy link
Member

First (if I recall correctly...?) merged PR means you're eligible for our famous sticker pack! If you send me your post address via Twitter DM, Slack or Email I'll make sure you get our little Thank-You maybe even before Christmas!

@cnotin cnotin deleted the pr-datacreator-bonus branch December 3, 2020 21:55
@cnotin
Copy link
Contributor Author

cnotin commented Dec 3, 2020

Not the first PR attempt, but first to land for sure :) Thank you @bkimminich
I'll send my address via Twitter DM.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants