Apply product quantity limit per user on a per-order basis #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, all quantities from all prior purchases were counted in the quota stored in the purchaseQuantity model. Now only the quantity in the current order is checked as discussed in PR #1528 Signed-off-by: Clément Notin <clement@notin.org>
|
GitHub CI/CD looks nice 👏 except perhaps a little bug in e2e? |
|
It's work in progress, but it looks very promising. Even Docker builds work ready... Heroku and some notifications stuff and Travis-CI is obsolete for push/PR... 👍 |
|
Thanks for pinging our new build pipeline! 🥳 |
|
I'm hypnotized by it... so I couldn't help not launching it!! |
|
Sweet :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, all quantities from all prior purchases were counted in the quota stored in the purchaseQuantity model.
Now only the quantity in the current order is checked as discussed in PR #1528
No issue in
npm run lintandnpm run frisby