Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit hashes for plugins #1687

Merged
merged 3 commits into from
Sep 28, 2021

Conversation

commjoen
Copy link
Contributor

So, as described at https://xpirit.com/github-actions-running-them-securely/ it is best ot either fork an action (too much work) or use commit hashes for them.
Now the question becomes: at what level do we want to trust which action provider?
do we trust:

  • github
  • docker
  • ...that cool dude creating retry mechanisms?

The problem we have with the current tagging scheme is that tags are moved to new commits all the time. The problem we have with this is that we are now frozen on a given version,until we check for better versions.
What would you like to see?

@bkimminich bkimminich merged commit 9ce36f8 into juice-shop:develop Sep 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants