Improvements to NoSQL manipulation code fixes #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 29, 2021 14:43
Signed-off-by: Stefan Denker <Stefan@dn-kr.de>
Signed-off-by: Stefan Denker <Stefan@dn-kr.de>
J12934
approved these changes
Sep 29, 2021
|
Yup, as the person who wrote these I can confirm that this is exactly how I wanted them to be. Thanks you for the fix 👍 |
|
Hi @denkerszaf, now that your PR made it into the official release, you're eligible for a sticker pack as a first time contributor! If you mail or Slack-PM me your address, I'll make sure you'll get one. It might take a while as I tend to pile up a few such packages before going to the post office... :-) |
This was referenced Apr 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing your potential fixes, i noticed that none of them fixed the vulnerability.
Fix 1 checks the '$ne'-Attribute of the body itself, the fix needs to look into the id attribute... (Since this is a wrong solution I am not sure whether this is intentional or not)
Fix 3 checks if the value of id is not a number... This won't work, since the review ids are strings.
Feel free to edit as you like, Javascript is not my native language.