New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a (optional) newly redesigned ScoreBoard #2043
Conversation
Passing run #281 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
1 failed test on run #296 ↗︎
Details:
test/cypress/integration/e2e/complain.spec.ts • 1 failed test • chrome @ macos-latest
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
32ed474
to
55123e8
Compare
Woohoo, build passed! |
55123e8
to
f344070
Compare
Also did some work to align the design & code of all of these banners we have now: The old ScoreBoard now also features a navigation link to the new ScoreBoard. |
This PR has been automatically marked as |
950c16c
to
0555e4d
Compare
ah yes, always hard to spot on macs as it doesn't show scrollbars until you actually scroll :) |
Might be worthwhile to pull in ng-mocks to avoid some of the nested import which don't matter for these tests
Signed-off-by: JuiceShopBot <61591748+JuiceShopBot@users.noreply.github.com>
ff38ff4
to
0a5b61f
Compare
Description
This PR adds a new (currently) optional replacement of the ScoreBoard based on the designs of Vibhuti Arora.
The new Score Board looks something like the following and is currently available under the
/#/score-board-preview
path.The goal is to include the ScoreBoard as a optional replacement in the next release to get more user feedback and remove the existing ScoreBoard in a later release.
Open Todos
restrictToTutorialsFirst
mode in new ScoreBoard.Affirmation