Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new Crypto Wallet Exploit Challenge #2064

Merged
merged 8 commits into from Aug 30, 2023
Merged

Add a new Crypto Wallet Exploit Challenge #2064

merged 8 commits into from Aug 30, 2023

Conversation

rishabhkeshan
Copy link
Contributor

Description

Added the third Web3 challenge as part of GSoC'23, "Exploit the Crypto Wallet"

  • Added a new link with redirection to /wallet-web3 in the Digital Wallet page
  • Added a new page with 3 functionalities:
    1. Metamask Wallet Connect
      • Added metamask wallet connect button to connect to the Sepolia chain with error handling and snack notifications
    2. Deposit ETH
      • Added a functionality to deposit ETH into the digital crypto wallet.
    3. Withdraw ETH
      • Added a functionality to withdraw back the deposited ETH from the digital crypto wallet contract.
  • Added the required backend route for challenge solved check.

Affirmation

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 17, 2023
View reviewed changes
routes/web3Wallet.ts Fixed Show fixed Hide fixed
@rishabhkeshan rishabhkeshan marked this pull request as ready for review August 23, 2023 06:47
ShubhamPalriwala
ShubhamPalriwala requested changes Aug 26, 2023
View reviewed changes
Copy link
Member

@ShubhamPalriwala ShubhamPalriwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rishabhkeshan, the PR looks great to me 🚀! Can you just remove all the console logs and then we'll merge it?

routes/web3Wallet.ts Outdated Show resolved Hide resolved
frontend/src/app/wallet-web3/wallet-web3.component.ts Outdated Show resolved Hide resolved
frontend/src/app/wallet-web3/wallet-web3.component.ts Outdated Show resolved Hide resolved
frontend/src/app/wallet-web3/wallet-web3.component.ts Outdated Show resolved Hide resolved
frontend/src/app/wallet-web3/wallet-web3.component.ts Outdated Show resolved Hide resolved
frontend/src/app/wallet-web3/wallet-web3.component.ts Outdated Show resolved Hide resolved
frontend/src/app/wallet-web3/wallet-web3.component.ts Outdated Show resolved Hide resolved
frontend/src/app/wallet-web3/wallet-web3.component.ts Outdated Show resolved Hide resolved
frontend/src/app/wallet-web3/wallet-web3.component.ts Show resolved Hide resolved
frontend/src/app/wallet-web3/wallet-web3.component.ts Outdated Show resolved Hide resolved
@bkimminich bkimminich merged commit f267158 into juice-shop:develop Aug 30, 2023
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShubhamPalriwala ShubhamPalriwala ShubhamPalriwala approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rishabhkeshan @ShubhamPalriwala @bkimminich