Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chunk/cache: disable refreshCacheKeys if interval < 0 #2865

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

SandyXSD
Copy link
Contributor

This is a very special case, which will totally disable building index for the cached keys. Users have to be make sure by themselves that there is at lease one client building this index, so that it can upload staging blocks (if writeback is enabled) and do the cleanup of cache directory.

@codecov-commenter
Copy link

Codecov Report

Base: 59.33% // Head: 59.34% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (a0f4931) compared to base (2caf355).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2865      +/-   ##
==========================================
+ Coverage   59.33%   59.34%   +0.01%     
==========================================
  Files         140      140              
  Lines       24331    24333       +2     
==========================================
+ Hits        14436    14441       +5     
+ Misses       8044     8038       -6     
- Partials     1851     1854       +3     
Impacted Files Coverage Δ
pkg/chunk/disk_cache.go 74.95% <0.00%> (+0.69%) ⬆️
pkg/chunk/utils_unix.go 66.66% <0.00%> (-25.00%) ⬇️
pkg/vfs/writer.go 76.58% <0.00%> (-1.20%) ⬇️
pkg/meta/sql.go 64.40% <0.00%> (-0.34%) ⬇️
pkg/vfs/reader.go 79.20% <0.00%> (+0.21%) ⬆️
pkg/meta/tkv.go 75.48% <0.00%> (+0.45%) ⬆️
pkg/meta/tkv_mem.go 87.32% <0.00%> (+0.70%) ⬆️
pkg/fuse/context.go 75.00% <0.00%> (+10.71%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davies davies merged commit 9af5a48 into main Oct 17, 2022
@davies davies deleted the disable-cache-refresh branch October 17, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants