Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metric: fix stageBlockBytes calculation method #3462

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

zhijian-pro
Copy link
Contributor

@zhijian-pro zhijian-pro commented Apr 11, 2023

ref #3450

@zhijian-pro zhijian-pro added the backport-1.0 Backport to release-1.0 branch label Apr 11, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.02 🎉

Comparison is base (f1c475d) 60.93% compared to head (e58d884) 60.95%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.0    #3462      +/-   ##
===============================================
+ Coverage        60.93%   60.95%   +0.02%     
===============================================
  Files              138      138              
  Lines            26150    26148       -2     
===============================================
+ Hits             15934    15939       +5     
+ Misses            8301     8296       -5     
+ Partials          1915     1913       -2     
Impacted Files Coverage Δ
pkg/chunk/disk_cache.go 79.69% <83.33%> (-0.09%) ⬇️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhijian-pro zhijian-pro changed the title fix stageBlockBytes calculation method metric: fix stageBlockBytes calculation method Apr 11, 2023
@zhijian-pro zhijian-pro marked this pull request as ready for review April 12, 2023 01:58
@davies davies merged commit 8bf5c69 into release-1.0 Apr 12, 2023
@davies davies deleted the fix_stageBlockBytes_for_1.0 branch April 12, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-1.0 Backport to release-1.0 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants