Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object/gs: remove storage class settings #3536

Merged
merged 1 commit into from
Apr 27, 2023
Merged

object/gs: remove storage class settings #3536

merged 1 commit into from
Apr 27, 2023

Conversation

zhijian-pro
Copy link
Contributor

@zhijian-pro zhijian-pro commented Apr 27, 2023

image

The regional is an illegal value, which seems to be a bug

@zhijian-pro zhijian-pro added the backport-1.0 Backport to release-1.0 branch label Apr 27, 2023
@zhijian-pro zhijian-pro requested a review from davies April 27, 2023 05:27
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.14 🎉

Comparison is base (39cc73d) 56.40% compared to head (0f28199) 56.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3536      +/-   ##
==========================================
+ Coverage   56.40%   56.54%   +0.14%     
==========================================
  Files         149      149              
  Lines       36420    36419       -1     
==========================================
+ Hits        20542    20594      +52     
+ Misses      13620    13567      -53     
  Partials     2258     2258              
Impacted Files Coverage Δ
pkg/object/gs.go 1.75% <0.00%> (+0.01%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davies davies merged commit 6e24e26 into main Apr 27, 2023
@davies davies deleted the fix_gs_storage_class branch April 27, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-1.0 Backport to release-1.0 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants