Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write syslog in background #3967

Merged
merged 1 commit into from
Aug 7, 2023
Merged

write syslog in background #3967

merged 1 commit into from
Aug 7, 2023

Conversation

davies
Copy link
Contributor

@davies davies commented Aug 4, 2023

Syslog could be slow or unavailable sometimes, it should not block logging.

@davies davies requested a review from SandyXSD August 4, 2023 13:03
@SandyXSD
Copy link
Contributor

SandyXSD commented Aug 6, 2023

Somehow the SDKTest always failed.

@SandyXSD
Copy link
Contributor

SandyXSD commented Aug 7, 2023

The test fails on the main branch as well.

@SandyXSD SandyXSD merged commit 62bc596 into main Aug 7, 2023
27 of 28 checks passed
@SandyXSD SandyXSD deleted the bg_syslog2 branch August 7, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants