Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the --verbose from native properties file #149

Merged
merged 1 commit into from Sep 26, 2022

Conversation

ngrunwald
Copy link
Contributor

the --verbose option in the file generates an error in recent version of native builder, as it should only be specified on the command line. This breaks compilation. Removing the switch from the properties file fixes the problem, and is backward compatible with older versions (at least in the sense that compilation won't break).

…d anymore

the --verbose option in the file generates an error in recent version of native builder
Copy link
Contributor

@huahaiy huahaiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. Is that the reason for failure?

Last time I checked, the latest version of graalvm is not compatible with Datalevin, I filed an issue at graalvm a couple of months ago. Don't think it is resolved.

@huahaiy huahaiy merged commit 8b72358 into juji-io:master Sep 26, 2022
@ngrunwald
Copy link
Contributor Author

Thanks! It seemed to be the reason, be at least the first problem encountered, the error stopped the compilation, but I've build a jar with the fix and you're right, the compilation breaks again further in the process with an illegal access to com.oracle.svm.core.jdk.localization.LocalizationFeature_OptionDescriptors. Well at least the fix will be useful when this is fixed by the maintainer :) Maybe we could add in the meantime a word in the readme to warn people and give the version of graalvm that's known to work? Which one are you using?

@huahaiy
Copy link
Contributor

huahaiy commented Sep 27, 2022

21.3.0 works. The latest version does not. The relevant issue is oracle/graal#4771

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants