Docs to go with the 0.1.0 release #14
Conversation
This commit restructures the core of charms.docker to follow the python best practice of import modules in the __init__.py file for a nicer UX You can now import like so: `from charms.docker import Compose` or `from charms.docker import DockerOpts` This also brings with it a pretty hefty update to the Compose class, implementing methods and tests for the following methods: - start - stop - pull - restart - build - scale It also splits apart the private __run method into a separate module known as 'runner'.
|
Changes Unknown when pulling aaad87f on chuckbutler:Docs into * on juju-solutions:master*. |
| a charmer. Provides stateless operations of a running docker daemon | ||
| ''' | ||
|
|
||
| def __init__(self, socket="unix:///var/run/docker.sock", workspace=None): |
There was a problem hiding this comment.
too many slashes here. I don't think you were intending for unix colon slash slash slash
There was a problem hiding this comment.
Are you sure? :) See the daemon options, specifically the -H option: https://docs.docker.com/engine/quickstart/
There was a problem hiding this comment.
OK I see the issue, it is using the third slash as the root dir. If this is correct, you should fix all other uses that do not have three slashes.
There was a problem hiding this comment.
Done, and done. Thanks for pointing that out, I completely missed it even after you called out the funky one that was indeed correct. #whatamidoingwithmylife
|
Changes Unknown when pulling 928d11c on chuckbutler:Docs into * on juju-solutions:master*. |
|
Changes Unknown when pulling 26debea on chuckbutler:Docs into * on juju-solutions:master*. |
|
The code looks good to me. I am not a restructured text expert, so not sure there. The coverage is high and the tests pass +1. |
No description provided.