Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

validate upstream downloads when building snaps #14

Closed
kwmonroe opened this issue Mar 29, 2018 · 1 comment
Closed

validate upstream downloads when building snaps #14

kwmonroe opened this issue Mar 29, 2018 · 1 comment

Comments

@kwmonroe
Copy link

I almost had a bad day. I ran build-and-release-kubernetes-snaps with a version param of 1.10.0. The correct param is v1.10.0. Missing the v is bad:

https://ci.kubernetes.juju.solutions/job/build-and-release-kubernetes-snaps/337/console

Notice that I made it all the way to the kubernetes-test snap before a failure. Turns out all the binaries pulled during that job were not binaries at all, but rather xml docs telling me "foo doesn't exist".

We don't validate the downloads are what we expect, and snapcraft happily packaged up our garbage and would have pushed them to the store if not for the lucky failure when preparing kubernetes-test (lucky because the snapcraft prepare phase tried to untar a xml doc).

We should do a simple file validation to ensure what we download from upstream is in fact what we expect.

@kwmonroe
Copy link
Author

kwmonroe commented Apr 4, 2018

Closed in #15

@kwmonroe kwmonroe closed this as completed Apr 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant