This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Fix snap configuration not properly handling boolean false values #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I manually tested this change in a live deployment. Cluster came up fine and e2e passed with no failures. Verified kubelet was started with --anonymous-auth=false. For automated testing, my plan is to add a validator to our CDK integration tests in a separate PR. |
|
LGTM +1 thank you! |
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Jul 3, 2017
…ices Automatic merge from submit-queue (batch tested with PRs 48439, 48440, 48394) Fix kubernetes charms not restarting services after snap upgrades **What this PR does / why we need it**: This fixes a problem where the Kubernetes charms don't restart services after upgrading snaps. This can cause certain fixes not to be picked up (for example juju-solutions/release#10) **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note Fixed kubernetes charms not restarting services after snap upgrades ```
tvansteenburgh
pushed a commit
to charmed-kubernetes/charm-kubernetes-control-plane
that referenced
this pull request
Apr 1, 2019
…ices Automatic merge from submit-queue (batch tested with PRs 48439, 48440, 48394) Fix kubernetes charms not restarting services after snap upgrades **What this PR does / why we need it**: This fixes a problem where the Kubernetes charms don't restart services after upgrading snaps. This can cause certain fixes not to be picked up (for example juju-solutions/release#10) **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note Fixed kubernetes charms not restarting services after snap upgrades ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/314
The resultings args file for kubelet looks like this, for example: