Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApacheSSLContext.enable_modules produces unnecessary output #148

Open
ajkavanagh opened this issue Apr 11, 2018 · 0 comments
Open

ApacheSSLContext.enable_modules produces unnecessary output #148

ajkavanagh opened this issue Apr 11, 2018 · 0 comments

Comments

@ajkavanagh
Copy link
Contributor

This context function (which is run everytime the class instance is used) generates the following output:

Considering dependency setenvif for ssl:
Module setenvif already enabled
Considering dependency mime for ssl:
Module mime already enabled
Considering dependency socache_shmcb for ssl:
Module socache_shmcb already enabled
Module ssl already enabled
Module proxy already enabled
Considering dependency proxy for proxy_http:
Module proxy already enabled
Module proxy_http already enabled
Module headers already enabled

The function responsible is:

class ApacheSSLContext(OSContextGenerator):                                              

    ...

                                                                                  
     def enable_modules(self):                                                    
         cmd = ['a2enmod', 'ssl', 'proxy', 'proxy_http', 'headers']               
         check_call(cmd) 

If this were changed to:

     def enable_modules(self):                                                    
         cmd = ['a2enmod', 'ssl', 'proxy', 'proxy_http', 'headers', '1>/dev/null']               
         check_call(cmd, shell=True)

then the standard cruft would go, but we'd still get error messages. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant