Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy_nrpe_checks doesn't verify the directory to copy from. #246

Open
ajkavanagh opened this issue Nov 22, 2018 · 0 comments
Open

copy_nrpe_checks doesn't verify the directory to copy from. #246

ajkavanagh opened this issue Nov 22, 2018 · 0 comments

Comments

@ajkavanagh
Copy link
Collaborator

Due to LP:#1796830 it turns out that the copy_nrpe_checks() function assumes that charmhelpers will always be installed in the hooks directory (which was probably a reasonable assumption). However, certain issues around converting PY2 charms to PY3 charms has meant, that for some charms, charmhelpers is better placed in the CHARMDIR. This has the unfortunate effect of breaking copy_nrpe_checks.
ajkavanagh added a commit to ajkavanagh/charm-helpers that referenced this issue Nov 23, 2018
@ajkavanagh
Update copy_nrpe_checks() for optional c-h directory
8a351d8 
The function assumed that the charmhelpers directory would always be in
the hooks directory.  However, with PY3 it can be very tricky to try to
keep a symlink in the hooks directory.  Therefore, for some PY3
non-reactive charms, charmhelpers was moved to the CHARMDIR.  However,
this caused this function to fail.

The change here is to search for the charmhelpers directory in both
CHARMDIR and CHARMDIR/hooks and then use that.

Closes-Bug: juju#246
LP-Bug: #1796830
@ajkavanagh ajkavanagh mentioned this issue Nov 23, 2018
Merged
ajkavanagh added a commit to ajkavanagh/charm-helpers that referenced this issue Nov 23, 2018
@ajkavanagh
Update copy_nrpe_checks() for optional c-h directory
9788e37 
The function assumed that the charmhelpers directory would always be in
the hooks directory.  However, with PY3 it can be very tricky to try to
keep a symlink in the hooks directory.  Therefore, for some PY3
non-reactive charms, charmhelpers was moved to the CHARMDIR.  However,
this caused this function to fail.

The change here is to search for the charmhelpers directory in both
CHARMDIR and CHARMDIR/hooks and then use that.

Closes-Bug: juju#246
LP-Bug: #1796830
thedac pushed a commit that referenced this issue Nov 26, 2018
@ajkavanagh @thedac
Update copy_nrpe_checks() for optional c-h directory (#247)
4b226ef 
The function assumed that the charmhelpers directory would always be in
the hooks directory.  However, with PY3 it can be very tricky to try to
keep a symlink in the hooks directory.  Therefore, for some PY3
non-reactive charms, charmhelpers was moved to the CHARMDIR.  However,
this caused this function to fail.

The change here is to search for the charmhelpers directory in both
CHARMDIR and CHARMDIR/hooks and then use that.

Closes-Bug: #246
LP-Bug: #1796830
ajkavanagh added a commit to ajkavanagh/charm-helpers that referenced this issue Nov 27, 2018
@ajkavanagh
Update copy_nrpe_checks() for optional c-h directory (juju#247)
d6e3ae3 
The function assumed that the charmhelpers directory would always be in
the hooks directory.  However, with PY3 it can be very tricky to try to
keep a symlink in the hooks directory.  Therefore, for some PY3
non-reactive charms, charmhelpers was moved to the CHARMDIR.  However,
this caused this function to fail.

The change here is to search for the charmhelpers directory in both
CHARMDIR and CHARMDIR/hooks and then use that.

Closes-Bug: juju#246
LP-Bug: #1796830
@ajkavanagh ajkavanagh mentioned this issue Nov 27, 2018
Merged
ryan-beisner pushed a commit that referenced this issue Nov 27, 2018
@ajkavanagh @ryan-beisner
Update copy_nrpe_checks() for optional c-h directory (#247) (#251)
87af6df 
The function assumed that the charmhelpers directory would always be in
the hooks directory.  However, with PY3 it can be very tricky to try to
keep a symlink in the hooks directory.  Therefore, for some PY3
non-reactive charms, charmhelpers was moved to the CHARMDIR.  However,
this caused this function to fail.

The change here is to search for the charmhelpers directory in both
CHARMDIR and CHARMDIR/hooks and then use that.

Closes-Bug: #246
LP-Bug: #1796830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ajkavanagh