Support python dict in sysctl_create #15
Conversation
Add support for directly passing a python dict rather than a YAML formatted string to sysctl_create to make it easier for charms to set sane defaults without hopping via YAML first.
javacruft
force-pushed
the
sysctl-pass-as-dict
branch
from
da4b2d3
to
f963305
Compare
| log("Error parsing YAML sysctl_dict: {}".format(sysctl_dict), | ||
| level=ERROR) | ||
| return | ||
| if type(sysctl_dict) is not dict: |
There was a problem hiding this comment.
This would probably be more flexible if it used:
if isinstance(syctl_dict, dict):as it would allow dict like objects to also be used. If you wanted to be really flexible, then you could use:
if isinstance(sysctl_dict, collections.abc.Mapping):Then it would allow any object that supports the dictionary specific methods (e.g. getattr, iter, etc.) to be used.
| log("Error parsing YAML sysctl_dict: {}".format(sysctl_dict), | ||
| level=ERROR) | ||
| return | ||
| if type(sysctl_dict) is not dict: |
There was a problem hiding this comment.
You might consider using if not isinstance(sysctl_dict, collections.Mapping): instead, on the off chance that the charm wants to pass in, e.g., an OrderedDict instead. Not really a blocker, though, since the order wouldn't be preserved with the existing code, either.
There was a problem hiding this comment.
Indeed, collections.Mapping is Py2 compatible.
There was a problem hiding this comment.
importing collections.Mapping raises a warning under Py3.7, and should be collections.abc.Mapping. We might need a conditional import.
Add support for directly passing a python dict rather than a
YAML formatted string to sysctl_create to make it easier for
charms to set sane defaults without hopping via YAML first.