Fix the py35 issue with json not accepting bytestrings #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So Python 3.6+ is magic, in that it will accept any str type (str or bytes) in the json.loads() method. Unfortunately, xenial (py35) doesn't have this feature. This patch correctly handles the check_output output for the enabled_manager_modules() function.
openstack-gerrit
pushed a commit
to openstack/charm-ceph-proxy
that referenced
this pull request
Oct 15, 2019
Also clean up pre-existing pep8 violations in the files/* dir which was previously not covered by lint testing. Also clean-up mocking issues around apt-pkg replacements in the unit tests. Also fix py35 issue with enabled_manager_modules() function in the charmhelpers library (see juju/charm-helpers#387). Also fix the functional tests bundles so they actually test the version of OpenStack that the bundle indicates. Change-Id: I2c8d84fadc11311c622dd308c4694496872dc157
openstack-gerrit
pushed a commit
to openstack/openstack
that referenced
this pull request
Oct 15, 2019
* Update charm-ceph-proxy from branch 'master'
- Sync charm/ceph helpers, tox, and requirements
Also clean up pre-existing pep8 violations in the
files/* dir which was previously not covered by lint testing.
Also clean-up mocking issues around apt-pkg replacements in the
unit tests.
Also fix py35 issue with enabled_manager_modules() function in the
charmhelpers library (see
juju/charm-helpers#387).
Also fix the functional tests bundles so they actually test the
version of OpenStack that the bundle indicates.
Change-Id: I2c8d84fadc11311c622dd308c4694496872dc157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So Python 3.6+ is magic, in that it will accept any str type
(str or bytes) in the json.loads() method. Unfortunately, xenial
(py35) doesn't have this feature. This patch correctly handles the
check_output output for the enabled_manager_modules() function.