Ensure python3-hvac is installed for charms with encypt option #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The referenced bug is essentially: make vault:secrets relation to vault
but keep the 'encrypt' option as False. In this case, the Context
handling code in charm-helpers is expecting python3-hvac to be
available, but it is only installed if the encrypt option is set to
True. Hence the charm crashes. This resolves that crash.
The VautlKVContext()() returns {} if the hvac module isn't isntalled,
which essentially deactivates it.
Closes-bug: #1862085
ajkavanagh
force-pushed
the
bug/1862085
branch
from
96f6ca4
to
01ce3a6
Compare
openstack-gerrit
pushed a commit
to openstack/charm-swift-storage
that referenced
this pull request
Feb 20, 2020
The referenced bug is essentially: make vault:secrets relation to vault but keep the 'encrypt' option as False. In this case, the Context handling code in charm-helpers is expecting python3-hvac to be available, but it is only installed if the encrypt option is set to True. Hence the charm crashes. This resolves that crash. Note the related charm-helpers fix [1]. [1]: juju/charm-helpers#431 Change-Id: I92773b7c1f48d456091062751e69581fabe4c5f3 Closes-bug: #1862085
openstack-gerrit
pushed a commit
to openstack/openstack
that referenced
this pull request
Feb 20, 2020
* Update charm-swift-storage from branch 'master'
- Merge "Ensure python3-hvac is installed for charms with encypt option"
- Ensure python3-hvac is installed for charms with encypt option
The referenced bug is essentially: make vault:secrets relation to vault
but keep the 'encrypt' option as False. In this case, the Context
handling code in charm-helpers is expecting python3-hvac to be
available, but it is only installed if the encrypt option is set to
True. Hence the charm crashes. This resolves that crash.
Note the related charm-helpers fix [1].
[1]: juju/charm-helpers#431
Change-Id: I92773b7c1f48d456091062751e69581fabe4c5f3
Closes-bug: #1862085
openstack-gerrit
pushed a commit
to openstack/charm-ceph-osd
that referenced
this pull request
Feb 20, 2020
The referenced bug is essentially: make vault:secrets relation to vault but keep the 'encrypt' option as False. In this case, the Context handling code in charm-helpers is expecting python3-hvac to be available, but it is only installed if the encrypt option is set to True. Hence the charm crashes. This resolves that crash. Note the related charm-helpers fix [1]. [1]: juju/charm-helpers#431 Change-Id: I9cb60a9340554c91668272b46f7c2dcf9f0ac2d1 Closes-bug: #1862085
openstack-gerrit
pushed a commit
to openstack/openstack
that referenced
this pull request
Feb 20, 2020
* Update charm-ceph-osd from branch 'master'
- Merge "Ensure python3-hvac is installed for charms with encypt option"
- Ensure python3-hvac is installed for charms with encypt option
The referenced bug is essentially: make vault:secrets relation to vault
but keep the 'encrypt' option as False. In this case, the Context
handling code in charm-helpers is expecting python3-hvac to be
available, but it is only installed if the encrypt option is set to
True. Hence the charm crashes. This resolves that crash.
Note the related charm-helpers fix [1].
[1]: juju/charm-helpers#431
Change-Id: I9cb60a9340554c91668272b46f7c2dcf9f0ac2d1
Closes-bug: #1862085
openstack-gerrit
pushed a commit
to openstack/charm-nova-compute
that referenced
this pull request
Feb 20, 2020
The referenced bug is essentially: make vault:secrets relation to vault but keep the 'encrypt' option as False. In this case, the Context handling code in charm-helpers is expecting python3-hvac to be available, but it is only installed if the encrypt option is set to True. Hence the charm crashes. This resolves that crash. Note the related charm-helpers fix [1]. [1]: juju/charm-helpers#431 Change-Id: Ic02d4d4d3c3b423fa28cd171b126ed4a444fc646 Closes-bug: #1862085
openstack-gerrit
pushed a commit
to openstack/openstack
that referenced
this pull request
Feb 20, 2020
* Update charm-nova-compute from branch 'master'
- Merge "Ensure python3-hvac is installed for charms with encypt option"
- Ensure python3-hvac is installed for charms with encypt option
The referenced bug is essentially: make vault:secrets relation to vault
but keep the 'encrypt' option as False. In this case, the Context
handling code in charm-helpers is expecting python3-hvac to be
available, but it is only installed if the encrypt option is set to
True. Hence the charm crashes. This resolves that crash.
Note the related charm-helpers fix [1].
[1]: juju/charm-helpers#431
Change-Id: Ic02d4d4d3c3b423fa28cd171b126ed4a444fc646
Closes-bug: #1862085
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The referenced bug is essentially: make vault:secrets relation to vault
but keep the 'encrypt' option as False. In this case, the Context
handling code in charm-helpers is expecting python3-hvac to be
available, but it is only installed if the encrypt option is set to
True. Hence the charm crashes. This resolves that crash.
The VautlKVContext()() returns {} if the hvac module isn't isntalled,
which essentially deactivates it.
Closes-bug: #1862085