Fix directory /etc/nagios/nrpe.d/ issue #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedac
suggested changes
Jul 14, 2020
|
|
||
| # check that the charm can write to the conf dir. If not, then nagios | ||
| # probably isn't installed, and we can defer. | ||
| if not self.can_write_nrpe_conf_dir(): |
There was a problem hiding this comment.
Can we not just do a directory check?
if os.path.exists(cls.nrpe_confdir):
thedac
previously approved these changes
Jul 15, 2020
Under certain deployment conditions, the charm can attempt to write to the /etc/nagios/nrpe.d/ directory before it exists. This directory is created by the nrpe charm, but if the hacluster gets installed first, then it can be triggered to attempt to set up the nrpe entries before the directory can be created by nrpe. This change (and the associated charm-helpers change) ensures that the charm will delay the nrpe config until the directory is available (and thus, the nrpe charm is fully installed) Related Bug: LP: #1882557
openstack-mirroring
pushed a commit
to openstack/charm-hacluster
that referenced
this pull request
Jul 16, 2020
Under certain deployment conditions, the charm can attempt to write to the /etc/nagios/nrpe.d/ directory before it exists. This directory is created by the nrpe charm, but if the hacluster (this charm) gets installed first, then it can be triggered to attempt to set up the nrpe entries before the directory can be created by nrpe. This change (and the associated charm-helpers change) ensures that the charm will delay the nrpe config until the directory is available (and thus, the nrpe charm is fully installed) Related charm-helpers: juju/charm-helpers#492 Change-Id: Ibcbb5f56205b72c475807e3c34c64a00844908f4 Closes-Bug: #1882557
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Jul 16, 2020
* Update charm-hacluster from branch 'master'
- Merge "Fix directory /etc/nagios/nrpe.d/ issue"
- Fix directory /etc/nagios/nrpe.d/ issue
Under certain deployment conditions, the charm can attempt to write to
the /etc/nagios/nrpe.d/ directory before it exists. This directory is
created by the nrpe charm, but if the hacluster (this charm) gets
installed first, then it can be triggered to attempt to set up the nrpe
entries before the directory can be created by nrpe. This change (and
the associated charm-helpers change) ensures that the charm will delay
the nrpe config until the directory is available (and thus, the nrpe
charm is fully installed)
Related charm-helpers: juju/charm-helpers#492
Change-Id: Ibcbb5f56205b72c475807e3c34c64a00844908f4
Closes-Bug: #1882557
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain deployment conditions, the charm can attempt to write to
the /etc/nagios/nrpe.d/ directory before it exists. This directory is
created by the nrpe charm, but if the hacluster gets installed first,
then it can be triggered to attempt to set up the nrpe entries before
the directory can be created by nrpe. This change (and the associated
charm-helpers change) ensures that the charm will delay the nrpe config
until the directory is available (and thus, the nrpe charm is fully
installed)
Related Bug: LP: #1882557