Add elapsed time status updates for distributed_wait #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this may break tests, as it would no longer match 0 second sleep for leader unit, as the sleep would be bypassed as remaining = 0 |
afreiberger
force-pushed
the
issue540
branch
from
748a789
to
d6523c6
Compare
|
updated leader test to expect no waiting. |
ajkavanagh
reviewed
Apr 22, 2021
| # update status every 60 seconds with wait time elapsed | ||
| remaining_wait = calculated_wait | ||
| elapsed = 0 | ||
| while remaining_wait: |
There was a problem hiding this comment.
I think this would be more robust if it said:
while remaining_wait > 0:
...I know that by inspection the code will work, it's just the defensive programmer in me!
| @@ -531,7 +531,7 @@ def test_distributed_wait(self, log, modulo_distribution, sleep, | |||
| is_leader.return_value = True | |||
| cluster_utils.distributed_wait(modulo=9, wait=23) | |||
| modulo_distribution.assert_not_called() | |||
| sleep.assert_called_with(0) | |||
| sleep.assert_not_called(0) | |||
There was a problem hiding this comment.
It would probably be good to check that the looping does actually work here. i.e. verify that it works for an odd number of "not divisible by" 60 seconds wait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses issue #540 to provide operator feedback on elapsed time of long distributed wait times.