Use bindings for certificate requests #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing due to a pip 20.3.1 resolver error; #558 is a temporary fix, so when that lands merge from / rebase on master and this should pass. |
Pass a list of bindings to check in addition to the default API bindings. Ignore ADDRESS_MAP KeyErrors for charms that do not have the default API bindings. Closes-Bug: #1908306
thedac
changed the title
gnuoy
approved these changes
Jan 7, 2021
openstack-mirroring
pushed a commit
to openstack/charms.openstack
that referenced
this pull request
Jan 7, 2021
Charm-helpers PR must land first: juju/charm-helpers#556 Closes-Bug: #1908306 Change-Id: I7b3c4e11ab04cc133ffe6a718d5b505f27edad68
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Jan 7, 2021
* Update charms.openstack from branch 'master'
to d37b622a7b44415c7cd5f2e6bc20600b060a6f94
- Merge "Send bindings for get_certificate_requests"
- Send bindings for get_certificate_requests
Charm-helpers PR must land first:
juju/charm-helpers#556
Closes-Bug: #1908306
Change-Id: I7b3c4e11ab04cc133ffe6a718d5b505f27edad68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore ADDRESS_MAP KeyErrors
Just for a reference.
With a couple of changes to the charm and one to charms.openstack.charm.classes.get_certificate_requests, this works using the centralized helpers.