Deprecate local_address #569
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
network-get juju-info is likely to alphanumerically sort addresses and return the first rather than the "default" binding in the bundle. Replace all calls to local_address with network-get and an explicit binding. Partial-Bug: #1915578
ajkavanagh
reviewed
Feb 16, 2021
Comment on lines
+145
to
+147
| log( | ||
| "local_address is deprecated. Please find the call and replace it with " | ||
| "a network-get call with an explicit binding.", "WARNING") |
There was a problem hiding this comment.
If you wanted to be REALLY interesting/nasty here, you could use trace_back and print the stack at this point to tell them where the call is :) It might make the logs a bit messy, but would highlight the issue.
|
Out of date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
network-get juju-info is likely to alphanumerically sort addresses and
return the first rather than the "default" binding in the bundle.
Replace all calls to local_address with network-get and an explicit
binding.
Partial-Bug: #1915578