Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function for retrieving subordinate services #643

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Add function for retrieving subordinate services #643

merged 1 commit into from
Oct 1, 2021

Conversation

lourot
Copy link
Contributor

@lourot lourot commented Oct 1, 2021

@lourot
Copy link
Contributor Author

lourot commented Oct 1, 2021

This mechanism is being used in:

fnordahl
fnordahl approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@fnordahl fnordahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would like it if you followed along with a unit test case.

@fnordahl fnordahl merged commit 5ed3500 into juju:master Oct 1, 2021
@lourot lourot deleted the bug/1927277 branch October 1, 2021 14:41
@ajkavanagh
Copy link
Collaborator

Note: this didn't make it into the stable/21.10 release as that was cut earlier today. Is it needed for that?

openstack-mirroring pushed a commit to openstack/charm-nova-compute that referenced this pull request Nov 26, 2021
@lourot
Process subordinate releases packages map
8fb37dc 
For principal - subordinate plugin type relations where the
principal Python payload imports code from packages managed by a
subordinate, upgrades can be problematic.

This change will allow a subordinate charm that have opted into the
feature to inform its principal about all implemented release -
packages combinations ahead of time. With this information in place
the principal can do the upgrade in one operation without risk of
charm relation RPC type processing at a critical moment.

This makes use of
juju/charm-helpers#643

This is similar to
https://review.opendev.org/c/openstack/charm-keystone/+/781822

Also fixed broken link to charm-guide.

Change-Id: Iaf5b44be70ee108cbe88b4a26f0f15f915d507fe
Closes-Bug: #1927277
openstack-mirroring pushed a commit to openstack/openstack that referenced this pull request Nov 26, 2021
@openstack-gerrit
Update git submodules
b6e0f4d 
* Update charm-nova-compute from branch 'master'
  to 9724059fb9532708b76691f5a49a4d358e6027f8
  - Merge "Process subordinate releases packages map"
  - Process subordinate releases packages map
    
    For principal - subordinate plugin type relations where the
    principal Python payload imports code from packages managed by a
    subordinate, upgrades can be problematic.
    
    This change will allow a subordinate charm that have opted into the
    feature to inform its principal about all implemented release -
    packages combinations ahead of time. With this information in place
    the principal can do the upgrade in one operation without risk of
    charm relation RPC type processing at a critical moment.
    
    This makes use of
    juju/charm-helpers#643
    
    This is similar to
    https://review.opendev.org/c/openstack/charm-keystone/+/781822
    
    Also fixed broken link to charm-guide.
    
    Change-Id: Iaf5b44be70ee108cbe88b4a26f0f15f915d507fe
    Closes-Bug: #1927277
ajkavanagh pushed a commit to ajkavanagh/charm-helpers that referenced this pull request Feb 10, 2023
@lourot @ajkavanagh
Add function for retrieving subordinate services (juju#643)
934deac 
https://bugs.launchpad.net/charm-ceilometer-agent/+bug/1927277
openstack-mirroring pushed a commit to openstack/charm-nova-compute that referenced this pull request Feb 15, 2023
@lourot @ajkavanagh
Process subordinate releases packages map
acb628e 
For principal - subordinate plugin type relations where the
principal Python payload imports code from packages managed by a
subordinate, upgrades can be problematic.

This change will allow a subordinate charm that have opted into the
feature to inform its principal about all implemented release -
packages combinations ahead of time. With this information in place
the principal can do the upgrade in one operation without risk of
charm relation RPC type processing at a critical moment.

This makes use of
juju/charm-helpers#643

This is similar to
https://review.opendev.org/c/openstack/charm-keystone/+/781822

Also fixed broken link to charm-guide.

Note, that this includes a ch sync as part of the cherry-pick to pick up
the charm-helpers functions.

Change-Id: Iaf5b44be70ee108cbe88b4a26f0f15f915d507fe
Closes-Bug: #1927277
(cherry picked from commit 8fb37dc)
ajkavanagh added a commit that referenced this pull request Jun 30, 2023
@ajkavanagh @lourot
Add function for retrieving subordinate services (#643) (#754)
5f8dace 
https://bugs.launchpad.net/charm-ceilometer-agent/+bug/1927277

Co-authored-by: Aurelien Lourot <aurelien.lourot@canonical.com>
freyes pushed a commit to freyes/charm-helpers that referenced this pull request Aug 7, 2023
@lourot @freyes
Add function for retrieving subordinate services (juju#643)
989700d 
https://bugs.launchpad.net/charm-ceilometer-agent/+bug/1927277
(cherry picked from commit 5ed3500)
freyes pushed a commit to freyes/charm-helpers that referenced this pull request Aug 7, 2023
@lourot @freyes
Add function for retrieving subordinate services (juju#643)
45225ff 
https://bugs.launchpad.net/charm-ceilometer-agent/+bug/1927277
(cherry picked from commit 5ed3500)
freyes pushed a commit to freyes/charm-helpers that referenced this pull request Aug 7, 2023
@lourot @freyes
Add function for retrieving subordinate services (juju#643)
e598c69 
https://bugs.launchpad.net/charm-ceilometer-agent/+bug/1927277
(cherry picked from commit 5ed3500)
freyes pushed a commit to freyes/charm-helpers that referenced this pull request Aug 7, 2023
@lourot @freyes
Add function for retrieving subordinate services (juju#643)
2938e11 
https://bugs.launchpad.net/charm-ceilometer-agent/+bug/1927277
(cherry picked from commit 5ed3500)
freyes pushed a commit to freyes/charm-helpers that referenced this pull request Aug 9, 2023
@lourot @freyes
Add function for retrieving subordinate services (juju#643)
9fff167 
https://bugs.launchpad.net/charm-ceilometer-agent/+bug/1927277
(cherry picked from commit 5ed3500)
ajkavanagh added a commit that referenced this pull request Aug 11, 2023
@ajkavanagh
Merge pull request #834 from freyes/bug/1927277-wallaby
1bdbe6e 
Add function for retrieving subordinate services (#643)
ajkavanagh added a commit that referenced this pull request Aug 11, 2023
@ajkavanagh
Merge pull request #837 from freyes/bug/1927277-train
8ee805e 
Add function for retrieving subordinate services (#643)
ajkavanagh added a commit that referenced this pull request Aug 11, 2023
@ajkavanagh
Merge pull request #835 from freyes/bug/1927277-victoria
077fd25 
Add function for retrieving subordinate services (#643)
ajkavanagh added a commit that referenced this pull request Aug 11, 2023
@ajkavanagh
Merge pull request #836 from freyes/bug/1927277-ussuri
2056cba 
Add function for retrieving subordinate services (#643)
openstack-mirroring pushed a commit to openstack/charm-nova-compute that referenced this pull request Aug 22, 2023
@lourot @freyes
Process subordinate releases packages map
3a664fc 
For principal - subordinate plugin type relations where the
principal Python payload imports code from packages managed by a
subordinate, upgrades can be problematic.

This change will allow a subordinate charm that have opted into the
feature to inform its principal about all implemented release -
packages combinations ahead of time. With this information in place
the principal can do the upgrade in one operation without risk of
charm relation RPC type processing at a critical moment.

This makes use of
juju/charm-helpers#643

This is similar to
https://review.opendev.org/c/openstack/charm-keystone/+/781822

Also fixed broken link to charm-guide.

Change-Id: Iaf5b44be70ee108cbe88b4a26f0f15f915d507fe
Closes-Bug: #1927277
(cherry picked from commit 8fb37dc)
openstack-mirroring pushed a commit to openstack/charm-nova-compute that referenced this pull request Aug 22, 2023
@lourot @freyes
Process subordinate releases packages map
282830d 
For principal - subordinate plugin type relations where the
principal Python payload imports code from packages managed by a
subordinate, upgrades can be problematic.

This change will allow a subordinate charm that have opted into the
feature to inform its principal about all implemented release -
packages combinations ahead of time. With this information in place
the principal can do the upgrade in one operation without risk of
charm relation RPC type processing at a critical moment.

This makes use of
juju/charm-helpers#643

This is similar to
https://review.opendev.org/c/openstack/charm-keystone/+/781822

Also fixed broken link to charm-guide.

Change-Id: Iaf5b44be70ee108cbe88b4a26f0f15f915d507fe
Closes-Bug: #1927277
(cherry picked from commit 8fb37dc)
openstack-mirroring pushed a commit to openstack/charm-nova-compute that referenced this pull request Aug 22, 2023
@lourot @freyes
Process subordinate releases packages map
f31b199 
For principal - subordinate plugin type relations where the
principal Python payload imports code from packages managed by a
subordinate, upgrades can be problematic.

This change will allow a subordinate charm that have opted into the
feature to inform its principal about all implemented release -
packages combinations ahead of time. With this information in place
the principal can do the upgrade in one operation without risk of
charm relation RPC type processing at a critical moment.

This makes use of
juju/charm-helpers#643

This is similar to
https://review.opendev.org/c/openstack/charm-keystone/+/781822

Also fixed broken link to charm-guide.

Change-Id: Iaf5b44be70ee108cbe88b4a26f0f15f915d507fe
Closes-Bug: #1927277
(cherry picked from commit 8fb37dc)
openstack-mirroring pushed a commit to openstack/charm-nova-compute that referenced this pull request Aug 22, 2023
@lourot @freyes
Process subordinate releases packages map
8d30677 
For principal - subordinate plugin type relations where the
principal Python payload imports code from packages managed by a
subordinate, upgrades can be problematic.

This change will allow a subordinate charm that have opted into the
feature to inform its principal about all implemented release -
packages combinations ahead of time. With this information in place
the principal can do the upgrade in one operation without risk of
charm relation RPC type processing at a critical moment.

This makes use of
juju/charm-helpers#643

This is similar to
https://review.opendev.org/c/openstack/charm-keystone/+/781822

Also fixed broken link to charm-guide.

Change-Id: Iaf5b44be70ee108cbe88b4a26f0f15f915d507fe
Closes-Bug: #1927277
(cherry picked from commit 8fb37dc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnordahl fnordahl fnordahl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lourot @ajkavanagh @fnordahl