Utilities for configuring deferred restarts NRPE checks #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added new NRPE plugin 'check_deferred_restarts.py'. Charms can use
copy_nrpe_checks() to move it to the nagios plugin directory.
* Added {add,remove}_deferred_restarts_check utilities for adding and
removing the NRPE checks.
ajkavanagh
reviewed
Jan 14, 2022
Comment on lines
19
to
20
| """ | ||
| Return a list of deferred events dicts from policy-rc.d files |
There was a problem hiding this comment.
I know it's a touch picky, but please could you put the header of the docstring on the same line as the triple quotes (""")
There was a problem hiding this comment.
Done. I didn't do the same in nrpe.py because the rest of the file has them on different lines. Let me know if you think I should change those as well.
There was a problem hiding this comment.
No that's fine. I'm generally in favor of just gradually improving code, but to make those changes as well would probably just confuse the purpose of this PR. Thanks for make the changes!
charmhelpers/contrib/openstack/files/check_deferred_restarts.py
Outdated
Show resolved
Hide resolved
* nrpe.py * Add docstrings to the new functions. * check_deferred_restarts.py * Add copyright header. * Improve error handling for known error conditions. * Improve docstrings to add raised exceptions.
cornmetto
force-pushed
the
deferred-restarts-nrpe-check
branch
from
6d285db
to
0dd0638
Compare
ajkavanagh
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy_nrpe_checks() as needed to move it to the nagios plugin directory.
removing the NRPE checks.