[stable/antelope] Ensure get_requests_for_local_unit doesn't fail on incomplete relation (#824) #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…incomplete relation (#824) If the certificates relation has been set from a consuming charm for certificates, but the provider hasn't supplied a certificate, and the request is in the 'legacy' form, then the get_request_for_local_unit() function in cert_utils fails on accessing the (non-existant) 'ca' parameter in the databag. This patch ensures that if the 'ca' key is missing that the processing moves on to the next relation. (cherry-picked from: c8f4720) Closes LP#2028683
|
I imagine someone else will still have to sign off, but this change looks good to me |
openstack-mirroring
pushed a commit
to openstack/charm-cinder
that referenced
this pull request
Aug 22, 2023
…e relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#825 Closes-Bug: #2028683 Change-Id: Ia719ef3c34a6469056e8f2479a6c894615be1bcb
openstack-mirroring
pushed a commit
to openstack/charm-octavia
that referenced
this pull request
Aug 22, 2023
…e relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#825 Closes-Bug: #2028683 Change-Id: I0e7e2e67109f39a507b69de9d4f1e6abccf32f58
openstack-mirroring
pushed a commit
to openstack/charm-aodh
that referenced
this pull request
Aug 22, 2023
…e relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#825 Closes-Bug: #2028683 Change-Id: Ia7d8023d4f2003a469658faaf0b9459c9a67cb68
openstack-mirroring
pushed a commit
to openstack/charm-designate
that referenced
this pull request
Aug 22, 2023
…e relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#825 Closes-Bug: #2028683 Change-Id: I65b4309faaa53749e62feabea7edaa3930c20078
openstack-mirroring
pushed a commit
to openstack/charm-ironic-api
that referenced
this pull request
Aug 22, 2023
…e relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#825 Closes-Bug: #2028683 Change-Id: Ie91b970c7d8233bcd27e3ebaa5804e23ab40e443
openstack-mirroring
pushed a commit
to openstack/charm-ceilometer
that referenced
this pull request
Aug 22, 2023
…e relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#825 Closes-Bug: #2028683 Change-Id: I7128f06918ef5635c163e100c384fa154099c1eb
openstack-mirroring
pushed a commit
to openstack/charm-gnocchi
that referenced
this pull request
Aug 22, 2023
…e relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#825 Closes-Bug: #2028683 Change-Id: Ic37631b0c500b77f3dad9f0da5b50581c538dd51
openstack-mirroring
pushed a commit
to openstack/charm-nova-cloud-controller
that referenced
this pull request
Aug 22, 2023
…e relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#825 Closes-Bug: #2028683 Change-Id: I80b83b2a329de0e373c4444f89a55cf93528cdba
openstack-mirroring
pushed a commit
to openstack/charm-heat
that referenced
this pull request
Aug 22, 2023
…e relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#825 Closes-Bug: #2028683 Change-Id: Id5d5c693525d3832e657885acb44aaa99036d548
openstack-mirroring
pushed a commit
to openstack/charm-masakari
that referenced
this pull request
Aug 22, 2023
…e relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#825 Closes-Bug: #2028683 Change-Id: I5f342692a6e70fb4b3c9fbc27e39a2afed90e4ba
openstack-mirroring
pushed a commit
to openstack/charm-nova-cell-controller
that referenced
this pull request
Aug 22, 2023
…e relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#825 Closes-Bug: #2028683 Change-Id: Iac74be5df881a4c0af30b3fc941e14462f1a1556
openstack-mirroring
pushed a commit
to openstack/charm-openstack-dashboard
that referenced
this pull request
Aug 22, 2023
…e relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#825 Closes-Bug: #2028683 Change-Id: I2af4a66901d0092d457fb33ebaf14a3cc01f7764
openstack-mirroring
pushed a commit
to openstack/charm-placement
that referenced
this pull request
Aug 22, 2023
…e relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#825 Closes-Bug: #2028683 Change-Id: I4016b9c0fac509608013409e1106303bf796fd84
openstack-mirroring
pushed a commit
to openstack/charm-neutron-api
that referenced
this pull request
Sep 7, 2023
…e relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#825 Closes-Bug: #2028683 Change-Id: I1dba469a4a978d8a7728177dcd451ea4b5dce443
openstack-mirroring
pushed a commit
to openstack/charm-keystone
that referenced
this pull request
Sep 7, 2023
…e relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#825 Closes-Bug: #2028683 Change-Id: I8a4fcfbd596a35659632e6d92ff10fe2c7d98ea6
openstack-mirroring
pushed a commit
to openstack/charm-magnum
that referenced
this pull request
Sep 8, 2023
…e relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#825 Closes-Bug: #2028683 Change-Id: Idc21cf470293f2391d2945063bde73b8f83ea2c2
openstack-mirroring
pushed a commit
to openstack/charm-manila-ganesha
that referenced
this pull request
Sep 8, 2023
…e relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#825 Closes-Bug: #2028683 Change-Id: Ibfd4c57852ef2ddf2e26586cd6ad19c18cf48d6b
openstack-mirroring
pushed a commit
to openstack/charm-barbican
that referenced
this pull request
Sep 8, 2023
…e relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#825 Closes-Bug: #2028683 Change-Id: Ie16c0a33f84a78ddf6441135e77d98fef025c3b9
openstack-mirroring
pushed a commit
to openstack/charm-glance
that referenced
this pull request
Sep 20, 2023
…e relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#825 Closes-Bug: #2028683 Change-Id: I9f195752974b350e5cd4f1577d6225e0251f158d
openstack-mirroring
pushed a commit
to openstack/charm-manila
that referenced
this pull request
Sep 20, 2023
…e relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#825 Closes-Bug: #2028683 Change-Id: I03aeddba9eae1c76d0fd3af97cc1b01ffdbbdf60
openstack-mirroring
pushed a commit
to openstack/charm-swift-proxy
that referenced
this pull request
Oct 12, 2023
…e relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#825 Closes-Bug: #2028683 Func-Test-Pr: openstack-charmers/zaza-openstack-tests#1152 Change-Id: Ifbfd7571de866bb4e89a84bef966ae62e8b42410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the certificates relation has been set from a consuming charm for
certificates, but the provider hasn't supplied a certificate, and the
request is in the 'legacy' form, then the get_request_for_local_unit()
function in cert_utils fails on accessing the (non-existant) 'ca'
parameter in the databag. This patch ensures that if the 'ca' key is
missing that the processing moves on to the next relation.
(cherry-picked from: c8f4720)
Closes LP#2028683