[stable/yoga] Ensure get_requests_for_local_unit doesn't fail on incomplete relation (#824) #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplete relation (#824) If the certificates relation has been set from a consuming charm for certificates, but the provider hasn't supplied a certificate, and the request is in the 'legacy' form, then the get_request_for_local_unit() function in cert_utils fails on accessing the (non-existant) 'ca' parameter in the databag. This patch ensures that if the 'ca' key is missing that the processing moves on to the next relation. (cherry-picked from: c8f4720) Closes LP#2028683
|
This change looks good to me, but will probably require someone else's sign off |
openstack-mirroring
pushed a commit
to openstack/charm-neutron-api
that referenced
this pull request
Sep 7, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#827 Closes-Bug: #2028683 Change-Id: I9b528cf5cac173d886828afcc188692819ca8f83
openstack-mirroring
pushed a commit
to openstack/charm-keystone
that referenced
this pull request
Sep 7, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#827 Closes-Bug: #2028683 Change-Id: I12b6e8676fb8f95828424f76e8fdd3db9f9c07f3
openstack-mirroring
pushed a commit
to openstack/charm-ironic-api
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#827 Closes-Bug: #2028683 Change-Id: I214d62984423c50e4c32b051e64ab5b2e851b9a8
openstack-mirroring
pushed a commit
to openstack/charm-octavia
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#827 Closes-Bug: #2028683 Change-Id: I41ea5a58e0391d398fab2ecd44999e6f32a4054b
openstack-mirroring
pushed a commit
to openstack/charm-gnocchi
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#827 Closes-Bug: #2028683 Change-Id: I9c5c3776f00775a87217c817aa134dfc1d1e34c8
openstack-mirroring
pushed a commit
to openstack/charm-heat
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#827 Closes-Bug: #2028683 Change-Id: I26c4b6dbee9ce6bb620c270000b9e26bf303d2c8
openstack-mirroring
pushed a commit
to openstack/charm-aodh
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#827 Closes-Bug: #2028683 Change-Id: I7fde216402a15e0512361dcb89331f5cedd63563
openstack-mirroring
pushed a commit
to openstack/charm-nova-cell-controller
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#827 Closes-Bug: #2028683 Change-Id: I1982ea8027b4f7eef4f9fb5d5cede5119fbb52d0
openstack-mirroring
pushed a commit
to openstack/charm-masakari
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#827 Closes-Bug: #2028683 Change-Id: Ia9b78bd0710297342fee994776840557e809789e
openstack-mirroring
pushed a commit
to openstack/charm-nova-cloud-controller
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#827 Closes-Bug: #2028683 Change-Id: Ie984047ddd89fd3ed4976b9927b1ae59d58c31e1
openstack-mirroring
pushed a commit
to openstack/charm-placement
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#827 Closes-Bug: #2028683 Change-Id: I5129eef73c226688c6412015d834e639586f2db8
openstack-mirroring
pushed a commit
to openstack/charm-openstack-dashboard
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#827 Closes-Bug: #2028683 Change-Id: I86483878ea91c18ca2df117c4c938d14faf1a4fd
openstack-mirroring
pushed a commit
to openstack/charm-barbican
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#827 Closes-Bug: #2028683 Change-Id: I041f7603b166b128b0d8d4cf8f770de0088a95a4
openstack-mirroring
pushed a commit
to openstack/charm-manila-ganesha
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#827 Closes-Bug: #2028683 Change-Id: I0bc0db7d6ddd0bb4ad1174c7589d4581ca37ee2c
openstack-mirroring
pushed a commit
to openstack/charm-magnum
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#827 Closes-Bug: #2028683 Change-Id: I61a73c5c691ea2d180dd0346f104ba7400cfc2b5
openstack-mirroring
pushed a commit
to openstack/charm-cinder
that referenced
this pull request
Sep 13, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#827 Closes-Bug: #2028683 Change-Id: I4b15e69397b2de12cb8a30c5a9845234af52c8be
openstack-mirroring
pushed a commit
to openstack/charm-designate
that referenced
this pull request
Sep 13, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#827 Closes-Bug: #2028683 Change-Id: I448035f7e969d1ba73bc15b95c5698bc679c67e5
openstack-mirroring
pushed a commit
to openstack/charm-glance
that referenced
this pull request
Sep 20, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#827 Closes-Bug: #2028683 Change-Id: I76e0c796b142ff1b0472f4c22986a10e0000622d
openstack-mirroring
pushed a commit
to openstack/charm-manila
that referenced
this pull request
Sep 20, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#827 Closes-Bug: #2028683 Change-Id: I7d83d88abacf6fcfe1680779f6bb564908823df0
openstack-mirroring
pushed a commit
to openstack/charm-ceilometer
that referenced
this pull request
Sep 20, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#827 Closes-Bug: #2028683 Change-Id: I32806e1190727f4b9beff48bb7eb6ee591f2d6fd
openstack-mirroring
pushed a commit
to openstack/charm-swift-proxy
that referenced
this pull request
Oct 12, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#827 Closes-Bug: #2028683 Change-Id: I753486de8644d25201ec7138ec2190f66533a340
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the certificates relation has been set from a consuming charm for
certificates, but the provider hasn't supplied a certificate, and the
request is in the 'legacy' form, then the get_request_for_local_unit()
function in cert_utils fails on accessing the (non-existant) 'ca'
parameter in the databag. This patch ensures that if the 'ca' key is
missing that the processing moves on to the next relation.
(cherry-picked from: c8f4720)
Closes LP#2028683