[stable/wallaby] Ensure get_requests_for_local_unit doesn't fail on incomplete relation (#824) #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncomplete relation (#824) If the certificates relation has been set from a consuming charm for certificates, but the provider hasn't supplied a certificate, and the request is in the 'legacy' form, then the get_request_for_local_unit() function in cert_utils fails on accessing the (non-existant) 'ca' parameter in the databag. This patch ensures that if the 'ca' key is missing that the processing moves on to the next relation. (cherry-picked from: c8f4720) Closes LP#2028683
|
Looks good to me! Will need someone else to sign off for merge |
openstack-mirroring
pushed a commit
to openstack/charm-keystone
that referenced
this pull request
Sep 7, 2023
…te relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#829 Closes-Bug: #2028683 Change-Id: I170f3096d4988375022c303ba3daed1ec2ed665c
openstack-mirroring
pushed a commit
to openstack/charm-ironic-api
that referenced
this pull request
Sep 8, 2023
…te relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#829 Closes-Bug: #2028683 Change-Id: I3c7ca65fca93a43d659b3c4cd48ae2ef7dc35c79
openstack-mirroring
pushed a commit
to openstack/charm-octavia
that referenced
this pull request
Sep 8, 2023
…te relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#829 Closes-Bug: #2028683 Change-Id: Id883860c21bff001e693760a0535fd427e9c6d18
openstack-mirroring
pushed a commit
to openstack/charm-gnocchi
that referenced
this pull request
Sep 8, 2023
…te relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#829 Closes-Bug: #2028683 Change-Id: Ia9c81b7c0044f118ddaca29fc58d4d536d523107
openstack-mirroring
pushed a commit
to openstack/charm-nova-cell-controller
that referenced
this pull request
Sep 8, 2023
…te relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#829 Closes-Bug: #2028683 Change-Id: Icbec259056fb3932fedda62b54d99157145d49c8
openstack-mirroring
pushed a commit
to openstack/charm-openstack-dashboard
that referenced
this pull request
Sep 8, 2023
…te relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#829 Closes-Bug: #2028683 Change-Id: I5560c9a2c866d9ec067d4eb9a8f6926369ac1fc2
openstack-mirroring
pushed a commit
to openstack/charm-masakari
that referenced
this pull request
Sep 8, 2023
…te relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#829 Closes-Bug: #2028683 Change-Id: Idd192f1f96551abe301fd5b1dd5823a47a823d00
openstack-mirroring
pushed a commit
to openstack/charm-barbican
that referenced
this pull request
Sep 8, 2023
…te relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#829 Closes-Bug: #2028683 Change-Id: I7b5d3fd4ce975b94642c854a895cd25b9ddf0c53
openstack-mirroring
pushed a commit
to openstack/charm-manila-ganesha
that referenced
this pull request
Sep 8, 2023
…te relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#829 Closes-Bug: #2028683 Change-Id: Ie4a6922d433393513fce85dd6a23ba15cae56740
openstack-mirroring
pushed a commit
to openstack/charm-magnum
that referenced
this pull request
Sep 8, 2023
…te relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#829 Closes-Bug: #2028683 Change-Id: I6d9457c5d65f92fabfa8460560e5440cc956ba3b
openstack-mirroring
pushed a commit
to openstack/charm-placement
that referenced
this pull request
Sep 12, 2023
…te relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#829 Closes-Bug: #2028683 Change-Id: Idb19e008618ac018f9b1b25a71fa6dd9ac64fb6a
openstack-mirroring
pushed a commit
to openstack/charm-heat
that referenced
this pull request
Sep 13, 2023
…te relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#829 Closes-Bug: #2028683 Change-Id: Icfeb5abea5e64007e4a73964bb1b083b5bbe7107
openstack-mirroring
pushed a commit
to openstack/charm-nova-cloud-controller
that referenced
this pull request
Sep 13, 2023
…te relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#829 Closes-Bug: #2028683 Change-Id: Icf929c3c623ef1011f29a7c20ea2c9ac6df706f1
openstack-mirroring
pushed a commit
to openstack/charm-designate
that referenced
this pull request
Sep 13, 2023
…te relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#829 Closes-Bug: #2028683 Change-Id: Ie77594327658bb52cf72c5cf8d82fa4a0525fdf5
openstack-mirroring
pushed a commit
to openstack/charm-cinder
that referenced
this pull request
Sep 13, 2023
…te relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#829 Closes-Bug: #2028683 Change-Id: Ifc2fa48f101b9a43ec154261b3417b9f05b50850
openstack-mirroring
pushed a commit
to openstack/charm-neutron-api
that referenced
this pull request
Sep 13, 2023
…te relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#829 Closes-Bug: #2028683 Change-Id: Ie5fcf1db9033668c72f7aa09240915b9bf1ec851
openstack-mirroring
pushed a commit
to openstack/charm-glance
that referenced
this pull request
Sep 20, 2023
…te relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#829 Closes-Bug: #2028683 Change-Id: I3d24b8685fc924fb59e0bfde1ba140a95f6381b9
openstack-mirroring
pushed a commit
to openstack/charm-aodh
that referenced
this pull request
Sep 20, 2023
…te relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#829 Closes-Bug: #2028683 Change-Id: I7e452904c115d0c33f76e310a62c1aadd26653e7
openstack-mirroring
pushed a commit
to openstack/charm-manila
that referenced
this pull request
Sep 20, 2023
…te relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#829 Closes-Bug: #2028683 Change-Id: I04819767a90bbfc35e1d1a7c7cf9157042fdb894
openstack-mirroring
pushed a commit
to openstack/charm-ceilometer
that referenced
this pull request
Sep 20, 2023
…te relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#829 Closes-Bug: #2028683 Change-Id: If6d2f61cd826dbed62fcc0de4d530741b7a731bd
openstack-mirroring
pushed a commit
to openstack/charm-swift-proxy
that referenced
this pull request
Oct 12, 2023
…te relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#829 Closes-Bug: #2028683 Change-Id: I2cc8c017a793d8338d05e56d0f66e83d91bc756e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the certificates relation has been set from a consuming charm for
certificates, but the provider hasn't supplied a certificate, and the
request is in the 'legacy' form, then the get_request_for_local_unit()
function in cert_utils fails on accessing the (non-existant) 'ca'
parameter in the databag. This patch ensures that if the 'ca' key is
missing that the processing moves on to the next relation.
(cherry-picked from: c8f4720)
Closes LP#2028683