[stable/victoria] Ensure get_requests_for_local_unit doesn't fail on incomplete relation (#824) #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…incomplete relation (#824) If the certificates relation has been set from a consuming charm for certificates, but the provider hasn't supplied a certificate, and the request is in the 'legacy' form, then the get_request_for_local_unit() function in cert_utils fails on accessing the (non-existant) 'ca' parameter in the databag. This patch ensures that if the 'ca' key is missing that the processing moves on to the next relation. (cherry-picked from: c8f4720) Closes LP#2028683
|
Looks good to me. Will need someone else to merge |
openstack-mirroring
pushed a commit
to openstack/charm-neutron-api
that referenced
this pull request
Sep 13, 2023
…ete relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#830 Closes-Bug: #2028683 Change-Id: I8b24675510b29c007f81f2c581e5b9f06f4e6eab
openstack-mirroring
pushed a commit
to openstack/charm-keystone
that referenced
this pull request
Sep 13, 2023
…ete relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#830 Closes-Bug: #2028683 Change-Id: I5c07d891419e735fcbce5d72471547b8e12daee8
openstack-mirroring
pushed a commit
to openstack/charm-openstack-dashboard
that referenced
this pull request
Sep 13, 2023
…ete relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#830 Closes-Bug: #2028683 Change-Id: I64e42dbafdfb45668405b88e7f24a3727c161f9d
openstack-mirroring
pushed a commit
to openstack/charm-cinder
that referenced
this pull request
Sep 13, 2023
…ete relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#830 Closes-Bug: #2028683 Change-Id: I17c4811a05600a3244dd8303c2c3fa87b33913f8
openstack-mirroring
pushed a commit
to openstack/charm-barbican
that referenced
this pull request
Sep 13, 2023
…ete relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#830 Closes-Bug: #2028683 Change-Id: I66fb9f7f2cbb86087554f352ebce1ea4f29c5e8a
openstack-mirroring
pushed a commit
to openstack/charm-placement
that referenced
this pull request
Sep 13, 2023
…ete relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#830 Closes-Bug: #2028683 Change-Id: Ieadb546c363243eb3d47ae42b98d17a16df339bc
openstack-mirroring
pushed a commit
to openstack/charm-heat
that referenced
this pull request
Sep 13, 2023
…ete relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#830 Closes-Bug: #2028683 Change-Id: Ie7e69443ee181257d76fb4ca3e52a7ed20fdef61
openstack-mirroring
pushed a commit
to openstack/charm-nova-cloud-controller
that referenced
this pull request
Sep 13, 2023
…ete relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#830 Closes-Bug: #2028683 Change-Id: Ic9fae3cecb1fe07fcb8b6b2950795cd97b2c3a74
openstack-mirroring
pushed a commit
to openstack/charm-masakari
that referenced
this pull request
Sep 13, 2023
…ete relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. Update bundles so that pacemaker-remote uses focal/edge rather than the (non-existent) victoria/edge channel. [1] juju/charm-helpers#830 Closes-Bug: #2028683 Change-Id: I27a0acbfc53941a24d8cd852ea31673762d7779a
openstack-mirroring
pushed a commit
to openstack/charm-designate
that referenced
this pull request
Sep 13, 2023
…ete relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#830 Closes-Bug: #2028683 Change-Id: Id264fa959cd2c0a8d8e1053a1c70aa5cf6f89828
openstack-mirroring
pushed a commit
to openstack/charm-gnocchi
that referenced
this pull request
Sep 13, 2023
…ete relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. Added libpq-dev to bindep.txt for psycopg2-binary as no wheel exists for py3 anymore. [1] juju/charm-helpers#830 Closes-Bug: #2028683 Change-Id: I124f5e57176791407af398b5c177d9d1896f92d3
openstack-mirroring
pushed a commit
to openstack/charm-magnum
that referenced
this pull request
Sep 13, 2023
…ete relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#830 Closes-Bug: #2028683 Change-Id: I7083110054b0e15855b7ef6c4709cac332e6f199
openstack-mirroring
pushed a commit
to openstack/charm-nova-cell-controller
that referenced
this pull request
Sep 13, 2023
…ete relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. Also added bindep.txt for libpq-dev as the wheel for pysycopg-binary on py36 no longer exists. [1] juju/charm-helpers#830 Closes-Bug: #2028683 Change-Id: I5836db2321ae20b2ff43002a7937ab364982aa95
openstack-mirroring
pushed a commit
to openstack/charm-glance
that referenced
this pull request
Sep 20, 2023
…ete relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#830 Closes-Bug: #2028683 Change-Id: I34bb4e239fe999d3d54040583db0a98ef4c1a7ca
openstack-mirroring
pushed a commit
to openstack/charm-aodh
that referenced
this pull request
Sep 20, 2023
…ete relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. Add libpq-dev to bindep.txt for psycopg2-binary module as wheel no longer exists for py36. [1] juju/charm-helpers#830 Closes-Bug: #2028683 Change-Id: I2235468188dadd1861c6b22f3424411ecb2f51cd
openstack-mirroring
pushed a commit
to openstack/charm-manila
that referenced
this pull request
Sep 20, 2023
…ete relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. Added libpq-dev to bindep.txt for psycopg2-binary as wheel doesn't exist on py36. [1] juju/charm-helpers#830 Closes-Bug: #2028683 Change-Id: I6bef17dd4eb4e383639940357a9bc2875e01eee7
openstack-mirroring
pushed a commit
to openstack/charm-ceilometer
that referenced
this pull request
Sep 20, 2023
…ete relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#830 Closes-Bug: #2028683 Change-Id: Iaed9ef60a54823cc7c808767d5addbd34539bf5a
openstack-mirroring
pushed a commit
to openstack/charm-swift-proxy
that referenced
this pull request
Oct 12, 2023
…ete relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#830 Closes-Bug: #2028683 Change-Id: Ibfc1adb307039db30c6fda5235db32c7e52a1cf3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the certificates relation has been set from a consuming charm for
certificates, but the provider hasn't supplied a certificate, and the
request is in the 'legacy' form, then the get_request_for_local_unit()
function in cert_utils fails on accessing the (non-existant) 'ca'
parameter in the databag. This patch ensures that if the 'ca' key is
missing that the processing moves on to the next relation.
(cherry-picked from: c8f4720)
Closes LP#2028683