[stable/train] Ensure get_requests_for_local_unit doesn't fail on incomplete relation (#824) #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omplete relation (#824) If the certificates relation has been set from a consuming charm for certificates, but the provider hasn't supplied a certificate, and the request is in the 'legacy' form, then the get_request_for_local_unit() function in cert_utils fails on accessing the (non-existant) 'ca' parameter in the databag. This patch ensures that if the 'ca' key is missing that the processing moves on to the next relation. (cherry-picked from: c8f4720) Closes LP#2028683
|
Looks good to me. Will need someone else to merge. |
openstack-mirroring
pushed a commit
to openstack/charm-keystone
that referenced
this pull request
Sep 13, 2023
… relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#832 Closes-Bug: #2028683 Change-Id: I2ee75658fed16dfb8f616abd1e7950286bf5a671
openstack-mirroring
pushed a commit
to openstack/charm-neutron-api
that referenced
this pull request
Sep 13, 2023
… relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#832 Closes-Bug: #2028683 Change-Id: Ie679f22092dc317c7550a68e9ba493c291d65806
openstack-mirroring
pushed a commit
to openstack/charm-openstack-dashboard
that referenced
this pull request
Sep 13, 2023
… relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#832 Closes-Bug: #2028683 Change-Id: I07a812352107dbf7b861317799c88d8ff0aa8bd3
openstack-mirroring
pushed a commit
to openstack/charm-placement
that referenced
this pull request
Sep 13, 2023
… relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#832 Closes-Bug: #2028683 Change-Id: I5b3cb62f451654b54763c8c8e708f78472875fc1
openstack-mirroring
pushed a commit
to openstack/charm-cinder
that referenced
this pull request
Sep 13, 2023
… relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#832 Closes-Bug: #2028683 Change-Id: Ib2715ec0d915d44b98ca84f1fbefc358364f47fa
openstack-mirroring
pushed a commit
to openstack/charm-nova-cloud-controller
that referenced
this pull request
Sep 13, 2023
… relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#832 Closes-Bug: #2028683 Change-Id: Ie7b4b7a4cc8d1c79832a653900ea5d620c54ed9b
openstack-mirroring
pushed a commit
to openstack/charm-heat
that referenced
this pull request
Sep 13, 2023
… relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#832 Closes-Bug: #2028683 Change-Id: I92cff3db5aba8ca734d8a78a1875c2727360fb45
openstack-mirroring
pushed a commit
to openstack/charm-barbican
that referenced
this pull request
Sep 14, 2023
… relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#832 Closes-Bug: #2028683 Change-Id: I37d94af804cab24ad3e990ec8e8f41b9ca0fd984
openstack-mirroring
pushed a commit
to openstack/charm-designate
that referenced
this pull request
Sep 14, 2023
… relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#832 Closes-Bug: #2028683 Change-Id: Ib814df2764cae10a33cce2359b1da86fd940e0ce
openstack-mirroring
pushed a commit
to openstack/charm-gnocchi
that referenced
this pull request
Sep 14, 2023
… relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#832 Closes-Bug: #2028683 Change-Id: I807086e6ceaabf0805b2a35c5a2902652bbdc698
openstack-mirroring
pushed a commit
to openstack/charm-nova-cell-controller
that referenced
this pull request
Sep 14, 2023
… relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#832 Closes-Bug: #2028683 Change-Id: If4ceae535a84f13e1c1edd64fdd7110aafd8ef84
openstack-mirroring
pushed a commit
to openstack/charm-glance
that referenced
this pull request
Sep 20, 2023
… relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#832 Closes-Bug: #2028683 Change-Id: I2a1a1983770b1af6309f0d9848acbf13e41f077e
openstack-mirroring
pushed a commit
to openstack/charm-aodh
that referenced
this pull request
Sep 20, 2023
… relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#832 Closes-Bug: #2028683 Change-Id: I4610e4a6578f34ce2d685a77be534b6789639809
openstack-mirroring
pushed a commit
to openstack/charm-ceilometer
that referenced
this pull request
Sep 20, 2023
… relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#832 Closes-Bug: #2028683 Change-Id: I7d78b3c483230878676b572aa803d15a4f7a23f9
openstack-mirroring
pushed a commit
to openstack/charm-masakari
that referenced
this pull request
Sep 21, 2023
… relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#832 Closes-Bug: #2028683 Change-Id: I6e735e30ec7ba3edc85a1873569d2d98d286beb7
openstack-mirroring
pushed a commit
to openstack/charm-swift-proxy
that referenced
this pull request
Oct 12, 2023
… relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#832 Closes-Bug: #2028683 Change-Id: I9fcffdef27fed3b50df523ff8bb9f279ea6ef2c4
openstack-mirroring
pushed a commit
to openstack/charm-ironic-api
that referenced
this pull request
Dec 23, 2023
… relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#832 Closes-Bug: #2028683 Change-Id: Iebe98a4b7793cce9f7e8266a2efe218f46a77862
openstack-mirroring
pushed a commit
to openstack/charm-octavia
that referenced
this pull request
Dec 23, 2023
… relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#832 Closes-Bug: #2028683 Change-Id: I6619dc5ca6e6a0d4123f2958560e8a3a98c89446
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the certificates relation has been set from a consuming charm for
certificates, but the provider hasn't supplied a certificate, and the
request is in the 'legacy' form, then the get_request_for_local_unit()
function in cert_utils fails on accessing the (non-existant) 'ca'
parameter in the databag. This patch ensures that if the 'ca' key is
missing that the processing moves on to the next relation.
(cherry-picked from: c8f4720)
Closes LP#2028683