Add tests;

charmtools/charms.py

@@ -729,7 +729,7 @@ def validate_deployment(charm, linter):
         if field_type is None:
             linter.err('deployment.{} is not supported'.format(k))
         elif not isinstance(v, field_type):
-            linter.err('deployment.{} must be {} but got {}'.format(k, field_type, type(v)))
+            linter.err('deployment.{} must be {} but got {}'.format(k, field_type.__name__, type(v).__name__))
 
 
 def validate_extra_bindings(charm, linter):

tests/test_charm_proof.py

@@ -43,6 +43,7 @@
 from charmtools.charms import validate_actions  # noqa
 from charmtools.charms import validate_terms  # noqa
 from charmtools.charms import validate_resources  # noqa
+from charmtools.charms import validate_deployment  # noqa
 
 
 class TestCharmProof(TestCase):
@@ -814,6 +815,109 @@ def test_storage_proof_extensions(self):
         self.assertEqual(linter.err.call_args_list, [])
 
 
+
+class DeploymentValidationTest(TestCase):
+    def test_deployment(self):
+        """Charm has valid deployment."""
+        linter = Mock()
+        charm = {
+            'deployment': {
+                'type': 'stateful',
+                'service': 'omit',
+                'daemonset': True,
+                'min-version': "1.15",
+            }
+        }
+        validate_deployment(charm, linter)
+        self.assertFalse(linter.err.called)
+
+    def test_deployment_unsupported_field(self):
+        """Charm has the invalid deployment field."""
+        linter = Mock()
+        charm = {
+            'deployment': {
+                'type': 'stateful',
+                'service': 'omit',
+                'daemonset': True,
+                'min-version': "1.15",
+                'unknow-field': 'xxx',
+            }
+        }
+        validate_deployment(charm, linter)
+        self.assertEqual(linter.err.call_count, 1)
+        linter.err.assert_has_calls([
+            call('deployment.unknow-field is not supported'),
+        ], any_order=True)
+
+    def test_deployment_invalid_type(self):
+        """Charm has the invalid deployment type."""
+        linter = Mock()
+        charm = {
+            'deployment': {
+                'type': True,
+                'service': 'omit',
+                'daemonset': True,
+                'min-version': "1.15",
+            }
+        }
+        validate_deployment(charm, linter)
+        self.assertEqual(linter.err.call_count, 1)
+        linter.err.assert_has_calls([
+            call("deployment.type must be str but got bool"),
+        ], any_order=True)
+
+    def test_deployment_invalid_service(self):
+        """Charm has the invalid deployment service."""
+        linter = Mock()
+        charm = {
+            'deployment': {
+                'type': 'stateful',
+                'service': 1,
+                'daemonset': True,
+                'min-version': "1.15",
+            }
+        }
+        validate_deployment(charm, linter)
+        self.assertEqual(linter.err.call_count, 1)
+        linter.err.assert_has_calls([
+            call("deployment.service must be str but got int"),
+        ], any_order=True)
+
+    def test_deployment_invalid_daemonset(self):
+        """Charm has the invalid deployment daemonset."""
+        linter = Mock()
+        charm = {
+            'deployment': {
+                'type': 'stateful',
+                'service': 'omit',
+                'daemonset': 'True',
+                'min-version': "1.15",
+            }
+        }
+        validate_deployment(charm, linter)
+        self.assertEqual(linter.err.call_count, 1)
+        linter.err.assert_has_calls([
+            call("deployment.daemonset must be bool but got str"),
+        ], any_order=True)
+
+    def test_deployment_invalid_min_version(self):
+        """Charm has the invalid deployment min-version."""
+        linter = Mock()
+        charm = {
+            'deployment': {
+                'type': 'stateful',
+                'service': 'omit',
+                'daemonset': True,
+                'min-version': 1.15,
+            }
+        }
+        validate_deployment(charm, linter)
+        self.assertEqual(linter.err.call_count, 1)
+        linter.err.assert_has_calls([
+            call("deployment.min-version must be str but got float"),
+        ], any_order=True)
+
+
 class ResourcesValidationTest(TestCase):
     def test_minimal_resources_config(self):
         """Charm has the minimum allowed resources configuration."""