Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Req] charm-build exclude/ignore #602

Open
3 tasks done
rgildein opened this issue Feb 23, 2021 · 2 comments
Open
3 tasks done

[Feature Req] charm-build exclude/ignore #602

rgildein opened this issue Feb 23, 2021 · 2 comments

Comments

@rgildein
Copy link
Contributor

Checklist

  • Confirmed this is an issue with charm-tools, not charmstore-client
  • Provide versions of tools used
  • Described the feature or ways to replicate the issue

What version am I running?

I ran the following command: snap info charm and got the following ouput:

summary:   charm and charm-tools
publisher: Canonical✓
store-url: https://snapcraft.io/charm
contact:   https://discourse.juju.is/c/charming
license:   unset
description: |
  charmstore-client and charm-tools
commands:
  - charm
snap-id:      2Rryoc2ylScfbFl4eQtpntHD9iuZuMvt
tracking:     latest/stable
refresh-date: 21 days ago, at 02:20 CET
channels:
  latest/stable:    2.8.2               2021-02-01 (609) 119MB classic
  latest/candidate: 2.8.2               2021-02-01 (609) 119MB classic
  latest/beta:      2.8.2               2021-02-01 (609) 119MB classic
  latest/edge:      2.8.2+git-1-62b5015 2021-02-04 (614) 119MB classic
installed:          2.8.2                          (609) 119MB classic

I am using: Ubuntu 20.10

Issue/Feature

I believe it will be really useful to have an argument to exclude a file or directory when running charm-build. When working on reactive charms, I often rebuild my development version for testing purpose. These versions include my venv directory and the PyCharm helper directory (.idea). For this reason, the build takes longer as well as deployment of the charm. To avoid extending the deployment, I manually remove these directories from the charm-build directory.

I expect/expected the following

A command like this should not copy the venv and .idea directories to the builded charm

charm-build --log-level DEBUG -o ~/canonical/charm-build/ --exclude venv --exclude .idea .
@jameinel
Copy link
Member

jameinel commented Feb 23, 2021 via email

@rgildein
Copy link
Contributor Author

This is really helpful and I will use it, thanks.
However, this does help to deploy the charm, but the charm-build
still copies those directories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants