Add option for wheelhouse overrides #338
Conversation
To facilitate CI and testing of charms with new versions of Python dependencies, particularly those from base layers, you can now provide a wheelhouse.txt file via the `charm-build` CLI that will be applied after all others which can thus override any dependencies from lower layers.
| next_config, | ||
| ) | ||
| if existing_tactic is not None: | ||
| output_files['wheelhouse.txt'].combine(existing_tactic) |
There was a problem hiding this comment.
Should we combine or just be an overwrite?
There was a problem hiding this comment.
Nevermind, thinking about it combine makes more sense
There was a problem hiding this comment.
Combine merges the files. In fact, we end up with both versions of the files in the wheelhouse, which is also something that can happen with multiple layers referencing the same dep. It would be great to be able to resolve that up front, but that would require reimplementing much of pip's dependency resolution, so I'm disinclined to even try. It does generally do the right thing at the end, but it may be something we need to address eventually.
|
@marcoceppi I can look at adding / extending tests tomorrow. |
|
Thanks @johnsca, looks great! Should be in edge shortly. |
To facilitate CI and testing of charms with new versions of Python dependencies, particularly those from base layers, you can now provide a wheelhouse.txt file via the
charm-buildCLI that will be appliedafter all others which can thus override any dependencies from lower layers.