Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add option for wheelhouse overrides #338
Conversation
johnsca
requested review from
marcoceppi and
tvansteenburgh
Aug 24, 2017
| + next_config, | ||
| + ) | ||
| + if existing_tactic is not None: | ||
| + output_files['wheelhouse.txt'].combine(existing_tactic) |
johnsca
Aug 24, 2017
Member
Combine merges the files. In fact, we end up with both versions of the files in the wheelhouse, which is also something that can happen with multiple layers referencing the same dep. It would be great to be able to resolve that up front, but that would require reimplementing much of pip's dependency resolution, so I'm disinclined to even try. It does generally do the right thing at the end, but it may be something we need to address eventually.
|
@marcoceppi I can look at adding / extending tests tomorrow. |
|
Thanks @johnsca, looks great! Should be in edge shortly. |
marcoceppi
merged commit 5761a72
into
master
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
johnsca commentedAug 24, 2017
To facilitate CI and testing of charms with new versions of Python dependencies, particularly those from base layers, you can now provide a wheelhouse.txt file via the
charm-buildCLI that will be appliedafter all others which can thus override any dependencies from lower layers.