Feature/add deployment field2metadata #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycliuhw
force-pushed
the
feature/add-deployment-field2metadata
branch
from
7f92797
to
ac52e8d
Compare
wallyworld
reviewed
Sep 13, 2019
charmtools/charms.py
Outdated
| 'daemonset': bool, | ||
| 'min-version': str, | ||
| } | ||
| for k, v in deployment.items(): |
There was a problem hiding this comment.
can we also validate the allowed service types?
There was a problem hiding this comment.
yeah, changed the whole implementation and ensures this case now.
wallyworld
previously approved these changes
Sep 13, 2019
wallyworld
approved these changes
Sep 16, 2019
timClicks
pushed a commit
to timClicks/charm-tools
that referenced
this pull request
May 6, 2020
* Add 'deployment' field support in metadata.yaml * Add tests; * Change to use colander.MappingSchema to do validation on deployment; * Add tests for unsupported deployment.service, deployment.type;;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Checklist
make test?