Actions validation fixes #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrwren
pushed a commit
to jrwren/charm
that referenced
this pull request
Aug 6, 2014
Add charmstore commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time the Charm's Actions schema is loaded from YAML, gojsonschema
now uses its Validate method to ensure that the loaded schema conforms to
JSON-Schema Draft 4. The schema for JSON-Schema Draft 4 has been added
as an on-demand loaded definition to the charm package in order to avoid
remote queries to the spec.
This PR is a work in progress and needs discussion. See juju/juju#63 (comment) and http://paste.ubuntu.com/7625313/